From: Seungwon Jeon <tgih.jun@samsung.com>
To: 'Jaehoon Chung' <jh80.chung@samsung.com>,
'linux-mmc' <linux-mmc@vger.kernel.org>
Cc: 'Chris Ball' <cjb@laptop.org>,
'Will Newton' <will.newton@imgtec.com>,
'James Hogan' <james.hogan@imgtec.com>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'Shashidhar Hiremath' <shashidharh@vayavyalabs.com>
Subject: RE: [PATCH] mmc: dw-mmc: fixed secstion mismatch in reference
Date: Fri, 20 Jul 2012 20:36:01 +0900 [thread overview]
Message-ID: <001201cd666b$d7359800$85a0c800$%jun@samsung.com> (raw)
In-Reply-To: <50082569.8030002@samsung.com>
Hi Jaehoon,
July 20, 2012, Jaehoon Chung <jh80.chung@samsung.com>
> Fixed the below message.
>
> WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in reference from the function
> dw_mci_probe() to the function .init.text:dw_mci_init_slot()
> The function dw_mci_probe() references
> the function __init dw_mci_init_slot().
> This is often because dw_mci_probe lacks a __init
> annotation or the annotation of dw_mci_init_slot is wrong
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 72dc3cd..7955eba 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1760,7 +1760,7 @@ static void dw_mci_work_routine_card(struct work_struct *work)
> }
> }
>
> -static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> +static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> {
> struct mmc_host *mmc;
> struct dw_mci_slot *slot;
__init macro isn't required?
If so, how about adding __init macros to dw_mci_probe and dw_mci_pltfm_probe?
Best regards,
Seungwon Jeon
> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-20 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 15:19 [PATCH] mmc: dw-mmc: fixed secstion mismatch in reference Jaehoon Chung
2012-07-20 11:36 ` Seungwon Jeon [this message]
2012-07-23 1:52 ` Jaehoon Chung
2012-07-23 3:02 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001201cd666b$d7359800$85a0c800$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shashidharh@vayavyalabs.com \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).