From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seungwon Jeon Subject: RE: [PATCH v3] mmc: dw_mmc: read all data in FIFO after Data transfer over interrupt in pio mode Date: Mon, 18 Feb 2013 19:51:32 +0900 Message-ID: <001401ce0dc5$ea3b0d20$beb12760$%jun@samsung.com> References: <000401cdf874$97e25620$c7a70260$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=Windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:23986 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045Ab3BRKve (ORCPT ); Mon, 18 Feb 2013 05:51:34 -0500 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIE006TXWTFDXB0@mailout2.samsung.com> for linux-mmc@vger.kernel.org; Mon, 18 Feb 2013 19:51:33 +0900 (KST) Received: from DOTGIHJUN01 ([12.23.118.161]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIE00JX5WTWEQ10@mmp2.samsung.com> for linux-mmc@vger.kernel.org; Mon, 18 Feb 2013 19:51:33 +0900 (KST) In-reply-to: <000401cdf874$97e25620$c7a70260$%kim@samsung.com> Content-language: ko Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: 'Kyoungil Kim' , linux-mmc@vger.kernel.org Cc: 'Chris Ball' , 'Jaehoon Chung' Hi Chris, Could you merge this patch in your tree. We've verified. Thanks, Seungwon Jeon On Tuesday, January 22, 2013, Kyoungil Kim wrote: > In dwc manual, the below contents are described. > "During end of packet, interrupt is not generated if threshold > programming is larger than any remaining data. It is responsibility > of host to read remaining bytes on seeing Data Transfer Done > interrupt" > We also have seen the data cannot be read fully > when "sg_miter->length" is less than FIFO size. > > Signed-off-by: Kyoungil Kim > Signed-off-by: Seungwon Jeon > Acked-by: Jaehoon Chung > --- > drivers/mmc/host/dw_mmc.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 323c502..41d59da 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1430,7 +1430,7 @@ static void dw_mci_pull_data(struct dw_mci *host, void *buf, int cnt) > host->pull_data(host, buf, cnt); > } > > -static void dw_mci_read_data_pio(struct dw_mci *host) > +static void dw_mci_read_data_pio(struct dw_mci *host, bool dto) > { > struct sg_mapping_iter *sg_miter = &host->sg_miter; > void *buf; > @@ -1465,7 +1465,9 @@ static void dw_mci_read_data_pio(struct dw_mci *host) > sg_miter->consumed = offset; > status = mci_readl(host, MINTSTS); > mci_writel(host, RINTSTS, SDMMC_INT_RXDR); > - } while (status & SDMMC_INT_RXDR); /*if the RXDR is ready read again*/ > + /* if the RXDR is ready read again */ > + } while ((status & SDMMC_INT_RXDR) || > + (dto && SDMMC_GET_FCNT(mci_readl(host, STATUS)))); > data->bytes_xfered += nbytes; > > if (!remain) { > @@ -1597,7 +1599,7 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) > smp_wmb(); > if (host->dir_status == DW_MCI_RECV_STATUS) { > if (host->sg != NULL) > - dw_mci_read_data_pio(host); > + dw_mci_read_data_pio(host, true); > } > set_bit(EVENT_DATA_COMPLETE, &host->pending_events); > tasklet_schedule(&host->tasklet); > @@ -1606,7 +1608,7 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) > if (pending & SDMMC_INT_RXDR) { > mci_writel(host, RINTSTS, SDMMC_INT_RXDR); > if (host->dir_status == DW_MCI_RECV_STATUS && host->sg) > - dw_mci_read_data_pio(host); > + dw_mci_read_data_pio(host, false); > } > > if (pending & SDMMC_INT_TXDR) { > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html