From: Seungwon Jeon <tgih.jun@samsung.com>
To: 'Jaehoon Chung' <jh80.chung@samsung.com>,
'Sachin Kamat' <sachin.kamat@linaro.org>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org, patches@linaro.org
Subject: RE: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static
Date: Mon, 18 Feb 2013 19:51:50 +0900 [thread overview]
Message-ID: <001501ce0dc5$f470bab0$dd523010$%jun@samsung.com> (raw)
In-Reply-To: <5121F74E.5050903@samsung.com>
Hi Sachin,
You're right.
'dw_mci_exynos_probe' is only used here.
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
On Monday, February 18, 2013, Jaehoon Chung wrote:
> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> On 02/18/2013 05:53 PM, Sachin Kamat wrote:
> > Silences the following sparse warning:
> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > drivers/mmc/host/dw_mmc-exynos.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> > index 72fd0f2..5a09c77 100644
> > --- a/drivers/mmc/host/dw_mmc-exynos.c
> > +++ b/drivers/mmc/host/dw_mmc-exynos.c
> > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
> > };
> > MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
> >
> > -int dw_mci_exynos_probe(struct platform_device *pdev)
> > +static int dw_mci_exynos_probe(struct platform_device *pdev)
> > {
> > const struct dw_mci_drv_data *drv_data;
> > const struct of_device_id *match;
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-02-18 10:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 8:53 [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static Sachin Kamat
2013-02-18 8:53 ` [PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr() Sachin Kamat
2013-03-13 4:32 ` Jaehoon Chung
2013-03-13 14:17 ` Seungwon Jeon
2013-03-13 15:35 ` Sachin Kamat
2013-03-20 15:31 ` Sachin Kamat
2013-03-22 16:54 ` Chris Ball
2013-02-18 9:41 ` [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static Jaehoon Chung
2013-02-18 10:51 ` Seungwon Jeon [this message]
2013-03-04 4:36 ` Sachin Kamat
2013-03-12 9:22 ` Sachin Kamat
2013-03-12 13:03 ` Chris Ball
2013-03-12 14:52 ` Sachin Kamat
2013-03-12 15:00 ` Chris Ball
2013-03-12 15:04 ` Sachin Kamat
2013-03-13 4:20 ` Jaehoon Chung
2013-03-13 4:25 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001501ce0dc5$f470bab0$dd523010$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox