From: Seungwon Jeon <tgih.jun@samsung.com>
To: 'James Hogan' <james.hogan@imgtec.com>,
'Chris Ball' <cjb@laptop.org>,
'Will Newton' <will.newton@imgtec.com>,
'Thomas Abraham' <thomas.abraham@linaro.org>
Cc: 'Jaehoon Chung' <jh80.chung@samsung.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] dw_mmc: fix multiple drv_data NULL dereferences
Date: Tue, 16 Oct 2012 19:54:12 +0900 [thread overview]
Message-ID: <001701cdab8c$93e1eac0$bba5c040$%jun@samsung.com> (raw)
In-Reply-To: <1350376988-27477-1-git-send-email-james.hogan@imgtec.com>
On Tuesday, October 16, James Hogan <james.hogan@imgtec.com>
> Commit 800d78bfccb3d38116abfda2a5b9c8afdbd5ea21 ("mmc: dw_mmc: add
> support for implementation specific callbacks") merged in v3.7-rc1.
>
> The above commit introduced multiple NULL pointer dereferences when
> the default dw_mci_pltfm_probe() is used, as it sets host->drv_data to
> NULL, and that's only checked against NULL in 1 out of the 7 cases where
> it is dereferenced.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Looks good to me.
Thanks.
Seungwon Jeon
next prev parent reply other threads:[~2012-10-16 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 8:43 [PATCH] dw_mmc: fix multiple drv_data NULL dereferences James Hogan
2012-10-16 10:49 ` Thomas Abraham
2012-10-16 10:54 ` Seungwon Jeon [this message]
2012-10-17 2:06 ` Jaehoon Chung
2012-10-17 9:11 ` Will Newton
2012-10-29 9:34 ` James Hogan
2012-10-29 13:39 ` Chris Ball
2012-11-08 14:26 ` [PATCH] dw_mmc: fix more const pointer warnings Arnd Bergmann
2012-11-08 14:35 ` Chris Ball
2012-11-09 5:44 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001701cdab8c$93e1eac0$bba5c040$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox