* [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit
@ 2013-03-25 7:28 Seungwon Jeon
2013-03-26 12:02 ` Jaehoon Chung
2013-04-04 13:56 ` Chris Ball
0 siblings, 2 replies; 3+ messages in thread
From: Seungwon Jeon @ 2013-03-25 7:28 UTC (permalink / raw)
To: linux-mmc; +Cc: 'Chris Ball', 'Jaehoon Chung'
mci_writew causes a failure of fifo access for 64-bit.
mci_writeq is correct.
Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index a443820..753c55c 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1373,8 +1373,9 @@ static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt)
int len = dw_mci_push_part_bytes(host, buf, cnt);
buf += len;
cnt -= len;
+
if (host->part_buf_count == 8) {
- mci_writew(host, DATA(host->data_offset),
+ mci_writeq(host, DATA(host->data_offset),
host->part_buf);
host->part_buf_count = 0;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit
2013-03-25 7:28 [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit Seungwon Jeon
@ 2013-03-26 12:02 ` Jaehoon Chung
2013-04-04 13:56 ` Chris Ball
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2013-03-26 12:02 UTC (permalink / raw)
To: Seungwon Jeon; +Cc: linux-mmc, 'Chris Ball', 'Jaehoon Chung'
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 03/25/2013 04:28 PM, Seungwon Jeon wrote:
> mci_writew causes a failure of fifo access for 64-bit.
> mci_writeq is correct.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a443820..753c55c 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1373,8 +1373,9 @@ static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt)
> int len = dw_mci_push_part_bytes(host, buf, cnt);
> buf += len;
> cnt -= len;
> +
> if (host->part_buf_count == 8) {
> - mci_writew(host, DATA(host->data_offset),
> + mci_writeq(host, DATA(host->data_offset),
> host->part_buf);
> host->part_buf_count = 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit
2013-03-25 7:28 [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit Seungwon Jeon
2013-03-26 12:02 ` Jaehoon Chung
@ 2013-04-04 13:56 ` Chris Ball
1 sibling, 0 replies; 3+ messages in thread
From: Chris Ball @ 2013-04-04 13:56 UTC (permalink / raw)
To: Seungwon Jeon; +Cc: linux-mmc, 'Jaehoon Chung'
Hi,
On Mon, Mar 25 2013, Seungwon Jeon wrote:
> mci_writew causes a failure of fifo access for 64-bit.
> mci_writeq is correct.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a443820..753c55c 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1373,8 +1373,9 @@ static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt)
> int len = dw_mci_push_part_bytes(host, buf, cnt);
> buf += len;
> cnt -= len;
> +
> if (host->part_buf_count == 8) {
> - mci_writew(host, DATA(host->data_offset),
> + mci_writeq(host, DATA(host->data_offset),
> host->part_buf);
> host->part_buf_count = 0;
> }
Thanks, pushed to mmc-next for 3.10.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-04 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-25 7:28 [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit Seungwon Jeon
2013-03-26 12:02 ` Jaehoon Chung
2013-04-04 13:56 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox