From: Seungwon Jeon <tgih.jun@samsung.com>
To: 'Saugata Das' <saugata.das@linaro.org>
Cc: linux-mmc@vger.kernel.org
Subject: RE: Cache Control during mmc_suspend_host
Date: Fri, 16 Dec 2011 17:50:21 +0900 [thread overview]
Message-ID: <002901ccbbcf$be9b3990$3bd1acb0$%jun@samsung.com> (raw)
In-Reply-To: <CAKLKtzfQZrcG330Zf4EXx6rtZ6LZpxzpKnq5=z=fXOO1gZdvSg@mail.gmail.com>
Saugata Das wrote:
> On 14 December 2011 10:04, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> > Saugata Das wrote:
> >> On 13 December 2011 11:57, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> >> > Hi Saugata,
> >> >
> >> > Saugata Das wrote:
> >> >> Hi Seungwon Jeon
> >> >>
> >> >> I see a small issue with the implementation mmc_suspend_host,
> >> >>
> >> >> int mmc_suspend_host(struct mmc_host *host)
> >> >> {
> >> >> .....
> >> >> err = mmc_cache_ctrl(host, 0);
> >> >> }
> >> >>
> >> >> So, within mmc_suspend_host we are disabling the cache. But I do not
> >> >> see a corresponding enabling of cache within mmc_resume_host. I
> >> >> suggest we have either enabling of cache within mmc_resume_host or
> >> >> within mmc_suspend_host, we replace mmc_cache_ctrl(host, 0) with the
> >> >> flush operation, mmc_flush_cache(host->card).
> >> >>
> >> > Currently,
> >> > Cache is enabled in mmc_init_card() during mmc_resume_host().
> >> >
> >> Thanks for your answer.
> >>
> >> If mmc_card_keep_power is TRUE, then do you know why from mmc_resume
> >> we call mmc_init_card instead of just mmc_awake which should reduce
> >> some latency of system wakeup ?
> >>
> > I didn't find that case of keeping the power
> > during sleep in mmc unlike sdio.
>
> I am talking about keeping VCCQ ON and switching OFF only VCC. This is
> normally the SLEEP mode of eMMC, which provides quicker wakeup or
> resume. Some platforms will like to have quicker resume and will like
> to avoid doing a mmc_init_card during resume. If that happens, then
> the cache control disabling from mmc_suspend_host will be a problem.
> So, I suggest we change that to mmc_flush_cache which logically does
> the same as you wanted but it is also future proof.
Yes.
Currently mmc can wake up from sleep state using only CMD0 in mmc_init_card.
If we separate the escape route from sleep state, it must be considered.
Thank you for suggestion.
>
> >
> >>
> >> > Thanks,
> >> > Seungwon Jeon.
> >> >>
> >> >>
> >> >> Regards
> >> >> Saugata
> >> >> --
> >> >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> >> >> the body of a message to majordomo@vger.kernel.org
> >> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >> >
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-12-16 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 5:02 Cache Control during mmc_suspend_host Saugata Das
2011-12-13 6:27 ` Seungwon Jeon
2011-12-13 10:37 ` Saugata Das
2011-12-14 4:34 ` Seungwon Jeon
2011-12-15 10:08 ` Saugata Das
2011-12-16 8:50 ` Seungwon Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002901ccbbcf$be9b3990$3bd1acb0$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=saugata.das@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox