From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01689C7EE43 for ; Mon, 12 Jun 2023 09:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232953AbjFLJEH (ORCPT ); Mon, 12 Jun 2023 05:04:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231477AbjFLJDo (ORCPT ); Mon, 12 Jun 2023 05:03:44 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FB304224 for ; Mon, 12 Jun 2023 01:59:47 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6036E81DCF; Mon, 12 Jun 2023 10:59:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1686560386; bh=0IgdLp9xKA5F/lS/LpP0t1oh4VaHFjswb4uok/+IqBw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=wIcWBnAOk+gs7e9/6Fyr9ebipl0HeoCjS7VJGAJ4hkaODmWaQmDa1QvFJS2K/EWr3 QUlmBaihJgiblyzQofHMDxBmqdKx2oE0A1xM+sqLoWfGElYH+4691EgjpVH64s88fz Fake9y6sI5lK2oMUMkWtEtp24w+rZuQy9O2UrU1Szdjcx4iCYqMe44E1+poID7BbAH q920RQRUWTVb4fFEdCqkAf2tdWiwyQUByl1rDuAWBuEdl3Pxu/Krmo3RTyKTwPrpjs pfote6IW+8D1cW5r71wvt6jlr7/wcWlOzQMVIdFocLft+FnhFvIZpmxPvbHfIXlule 8LCt3ecgYhj5A== Message-ID: <0029620e-4d22-d8f9-5566-4b1ea7f05bae@denx.de> Date: Mon, 12 Jun 2023 10:59:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] [RFC] Revert "mmc: core: Fixup support for writeback-cache for eMMC and SD" Content-Language: en-US To: Adrian Hunter , linux-mmc@vger.kernel.org Cc: =?UTF-8?Q?Christian_L=c3=b6hle?= , Avri Altman , Jens Axboe , Michael Wu , Ming Lei , Seunghui Lee , Ulf Hansson References: <20230531002740.1235620-1-marex@denx.de> <29a5f24d-2b8c-8387-8c11-601af8e13940@denx.de> <4c8d84ae-c8d0-fa12-81c6-a47382684d73@intel.com> <3bd65a30-756d-e7ee-ce77-e5ebfe6b6e30@denx.de> <75ab27e9-9203-f59b-c720-99bfa992bb9b@intel.com> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 6/12/23 06:59, Adrian Hunter wrote: > On 7/06/23 23:43, Marek Vasut wrote: >> On 6/4/23 18:30, Adrian Hunter wrote: >> >> [...] >> >>>>>>> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c >>>>>>> index 72b664ed90cf..9c3123867a99 100644 >>>>>>> --- a/drivers/mmc/core/sd.c >>>>>>> +++ b/drivers/mmc/core/sd.c >>>>>>> @@ -1313,6 +1313,8 @@ static int sd_flush_cache(struct mmc_host *host) >>>>>>>     { >>>>>>>         struct mmc_card *card = host->card; >>>>>>>         u8 *reg_buf, fno, page; >>>>>>> +    unsigned long timeout; >>>>>>> +    bool expired; >>>>>>>         u16 offset; >>>>>>>         int err; >>>>>>>     @@ -1338,11 +1340,15 @@ static int sd_flush_cache(struct mmc_host *host) >>>>>>>             goto out; >>>>>>>         } >>>>>>>     +    timeout = jiffies + msecs_to_jiffies(SD_WRITE_EXTR_SINGLE_TIMEOUT_MS) + 1; >>>>>>> +again: >>>>>>>         err = mmc_poll_for_busy(card, SD_WRITE_EXTR_SINGLE_TIMEOUT_MS, false, >>>>>>>                     MMC_BUSY_EXTR_SINGLE); >>>>>>>         if (err) >>>>>>>             goto out; >>>>>>>     +    expired = time_after(jiffies, timeout); >>>>>>> + >>>>>>>         /* >>>>>>>          * Read the Flush Cache bit. The card shall reset it, to confirm that >>>>>>>          * it's has completed the flushing of the cache. >>>>>>> @@ -1354,8 +1360,12 @@ static int sd_flush_cache(struct mmc_host *host) >>>>>>>             goto out; >>>>>>>         } >>>>>>>     -    if (reg_buf[0] & BIT(0)) >>>>>>> -        err = -ETIMEDOUT; >>>>>>> +    if (reg_buf[0] & BIT(0)) { >>>>>> >>>>>> I am getting here, multiple times, with expired=0 . >>>>> >>>>> So either the host controller's busy detection does not work, or the >>>>> card is not indicating busy by pulling down DAT0. >>>>> >>>>> Can you try to figure out which it is? >>>> >>>> The byte 261 bit 0 is never cleared, I had this looping for an hour and the 'Flush Cache' bit just never got cleared. The SD spec 6.00 and 9.00 both indicate the bit should be cleared by the card once cache flush is completed. >>>> >>>> I tried three different controllers now -- STM32MP15xx ARM MMCI, i.MX6Q uSDHC, laptop rtsx_pci_sdmmc , they all fail. >>>> >>>> I tried to find another card which also has cache, I cannot find any other card, all the rest report no cache. The kingston card SSR (see the 2ff in 6th field, the last f bit 2 is cache supported indication, SSR bit 330): >>>> >>>> 00000000:08000000:04009000:011b391e:00080000:0002ff00:03000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000: >>>> >>>> So either this card is weird, or the cards with cache are so rare that nobody noticed the problem yet. >>> >>> The patch set cover letter says it was tested with 64GB Sandisk Extreme PRO UHS-I A2 card >>> >>>     https://lore.kernel.org/linux-mmc/20210506145829.198823-1-ulf.hansson@linaro.org/ >> >> I got that one now, tested it, the cache bit is being cleared correctly. I also tested a few more cards and dumped their SSR too: >> >> Kingston Canvas Go! Plus: >> 80000000:08000000:04009000:011b391e:00080000:0002ff00:03000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000: >> Flush never finishes >> >> Sandisk Extreme PRO A2 64GiB: >> 80000000:08000000:04009000:0f05391e:00080000:0002fc00:03000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000: >> mmc0: flushing cache took 5 ms, 1 iterations, error 0 >> >> Goodram IRDM V30 A2 64GiB: >> 80000000:08000000:0400a001:00fd3a1e:00080000:00023c00:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000: >> mmc0: flushing cache took 5 ms, 1 iterations, error 0 >> >> Samsung Pro Plus 512GiB V30 A2 (ext reg general info is all zeroes, cache not enabled): >> 80000000:08000000:04009000:0811391e:00080000:0002fc00:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000:00000000: >> >>> I ordered a Kingston Canvas Go Plus card as you described but it won't arrive for a week. >> >> I'm really interested in what you would find with that one. > > It worked just fine, but maybe it is a newer version of hw / firmware - the date is 04/2023 > > $ grep -H . /sys/class/mmc_host/mmc0/mmc0\:5048/* > grep: /sys/class/mmc_host/mmc0/mmc0:5048/block: Is a directory > /sys/class/mmc_host/mmc0/mmc0:5048/cid:9f54495344363447614b1004af017400 > /sys/class/mmc_host/mmc0/mmc0:5048/csd:400e00325b590001cf9f7f800a400000 > /sys/class/mmc_host/mmc0/mmc0:5048/date:04/2023 > grep: /sys/class/mmc_host/mmc0/mmc0:5048/driver: Is a directory > /sys/class/mmc_host/mmc0/mmc0:5048/dsr:0x404 > /sys/class/mmc_host/mmc0/mmc0:5048/erase_size:512 > /sys/class/mmc_host/mmc0/mmc0:5048/fwrev:0x1 > /sys/class/mmc_host/mmc0/mmc0:5048/hwrev:0x6 > /sys/class/mmc_host/mmc0/mmc0:5048/manfid:0x00009f > /sys/class/mmc_host/mmc0/mmc0:5048/name:SD64G > /sys/class/mmc_host/mmc0/mmc0:5048/ocr:0x00200000 > /sys/class/mmc_host/mmc0/mmc0:5048/oemid:0x5449 > grep: /sys/class/mmc_host/mmc0/mmc0:5048/power: Is a directory > /sys/class/mmc_host/mmc0/mmc0:5048/preferred_erase_size:4194304 > /sys/class/mmc_host/mmc0/mmc0:5048/rca:0x5048 > /sys/class/mmc_host/mmc0/mmc0:5048/scr:0205848701006432 > /sys/class/mmc_host/mmc0/mmc0:5048/serial:0x4b1004af > /sys/class/mmc_host/mmc0/mmc0:5048/ssr:000000000800000004009000011b391e000800000002ff0003000000000000000000000000000000000000000000000000000000000000000000000000000000 > grep: /sys/class/mmc_host/mmc0/mmc0:5048/subsystem: Is a directory > /sys/class/mmc_host/mmc0/mmc0:5048/type:SD > /sys/class/mmc_host/mmc0/mmc0:5048/uevent:DRIVER=mmcblk > /sys/class/mmc_host/mmc0/mmc0:5048/uevent:MMC_TYPE=SD > /sys/class/mmc_host/mmc0/mmc0:5048/uevent:MMC_NAME=SD64G > /sys/class/mmc_host/mmc0/mmc0:5048/uevent:MODALIAS=mmc:block This one I have here is certainly older (this time tested on STM32MP135F): $ grep -H . /sys/class/mmc_host/mmc0/mmc0\:5048/* /sys/class/mmc_host/mmc0/mmc0:5048/cid:9f544953443634476136980065013b7e /sys/class/mmc_host/mmc0/mmc0:5048/csd:400e00325b590001cfff7f800a4000fa /sys/class/mmc_host/mmc0/mmc0:5048/date:11/2019 /sys/class/mmc_host/mmc0/mmc0:5048/dsr:0x404 /sys/class/mmc_host/mmc0/mmc0:5048/erase_size:512 /sys/class/mmc_host/mmc0/mmc0:5048/fwrev:0x1 /sys/class/mmc_host/mmc0/mmc0:5048/hwrev:0x6 /sys/class/mmc_host/mmc0/mmc0:5048/manfid:0x00009f /sys/class/mmc_host/mmc0/mmc0:5048/name:SD64G /sys/class/mmc_host/mmc0/mmc0:5048/ocr:0x00300000 /sys/class/mmc_host/mmc0/mmc0:5048/oemid:0x5449 /sys/class/mmc_host/mmc0/mmc0:5048/preferred_erase_size:4194304 /sys/class/mmc_host/mmc0/mmc0:5048/rca:0x5048 /sys/class/mmc_host/mmc0/mmc0:5048/scr:0205848701006432 /sys/class/mmc_host/mmc0/mmc0:5048/serial:0x36980065 /sys/class/mmc_host/mmc0/mmc0:5048/ssr:000000000800000004009000011b391e000800000002ff0003000000000000000000000000000000000000000000000000000000000000000000000000000000 /sys/class/mmc_host/mmc0/mmc0:5048/type:SD /sys/class/mmc_host/mmc0/mmc0:5048/uevent:DRIVER=mmcblk /sys/class/mmc_host/mmc0/mmc0:5048/uevent:MMC_TYPE=SD /sys/class/mmc_host/mmc0/mmc0:5048/uevent:MMC_NAME=SD64G /sys/class/mmc_host/mmc0/mmc0:5048/uevent:MODALIAS=mmc:block cid, csr, date, ocr, serial differ. Which SD host controller did you use ?