public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Seungwon Jeon <tgih.jun@samsung.com>
To: 'Jaehoon Chung' <jh80.chung@samsung.com>, linux-mmc@vger.kernel.org
Cc: chris@printf.net, ulf.hansson@linaro.org,
	zhangfei.gao@linaro.org, dinguyen@altera.com
Subject: RE: [PATCH 3/5] mmc: dw_mmc-exynos: add the MMC_CAP_ERASE by default.
Date: Tue, 13 May 2014 20:15:02 +0900	[thread overview]
Message-ID: <002b01cf6e9c$962e8b60$c28ba220$%jun@samsung.com> (raw)
In-Reply-To: <1399893256-7071-4-git-send-email-jh80.chung@samsung.com>

Hi Jaehoon,

I think we can remove MMC_CAP_ERASE from host's cap.

Can you check below patch?
[PATCH v4] mmc: remove MMC_CAP_ERASE to enable trim in eMMC/SD Device

Thanks,
Seungwon Jeon

On Mon, May 12, 2014, Jaehoon Chung wrote:
> To use the erase command, add the MMC_CAP_ERASE capability by default.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/mmc/host/dw_mmc-exynos.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 0fbc53a..46fafd8 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -386,10 +386,11 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot, u32 opcode,
> 
>  /* Common capabilities of Exynos4/Exynos5 SoC */
>  static unsigned long exynos_dwmmc_caps[4] = {
> -	MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
> -	MMC_CAP_CMD23,
> -	MMC_CAP_CMD23,
> -	MMC_CAP_CMD23,
> +	MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23 |
> +		MMC_CAP_ERASE,
> +	MMC_CAP_CMD23 | MMC_CAP_ERASE,
> +	MMC_CAP_CMD23 | MMC_CAP_ERASE,
> +	MMC_CAP_CMD23 | MMC_CAP_ERASE,
>  };
> 
>  static const struct dw_mci_drv_data exynos_drv_data = {
> --
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2014-05-13 11:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 11:14 [PATCH 0/5] mmc: dw_mmc: minor code cleanup Jaehoon Chung
2014-05-12 11:14 ` [PATCH 1/5] mmc: dw_mmc: fix the wrong condition checking Jaehoon Chung
2014-05-12 11:14 ` [PATCH 2/5] mmc: dw_mmc: remove the "supports-highspeed" property Jaehoon Chung
2014-05-12 15:48   ` Dinh Nguyen
2014-05-14  4:55     ` Jaehoon Chung
2014-05-14 20:17       ` Dinh Nguyen
2014-05-12 17:43   ` Dinh Nguyen
2014-05-14  4:55     ` Jaehoon Chung
2014-05-12 11:14 ` [PATCH 3/5] mmc: dw_mmc-exynos: add the MMC_CAP_ERASE by default Jaehoon Chung
2014-05-13 11:15   ` Seungwon Jeon [this message]
2014-05-13 12:27     ` Jaehoon Chung
2014-05-12 11:14 ` [PATCH 4/5] mmc: dw_mmc: add the specified capbilities2 of controller Jaehoon Chung
2014-05-12 11:14 ` [PATCH 5/5] mmc: dw_mmc: use the mmc regulator API into core.c Jaehoon Chung
2014-05-12 17:41   ` Dinh Nguyen
2014-05-14  4:55     ` Jaehoon Chung
2014-05-14  9:48   ` Yuvaraj Cd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002b01cf6e9c$962e8b60$c28ba220$%jun@samsung.com' \
    --to=tgih.jun@samsung.com \
    --cc=chris@printf.net \
    --cc=dinguyen@altera.com \
    --cc=jh80.chung@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox