From: Seungwon Jeon <tgih.jun@samsung.com>
To: "'Andrei E. Warkentin'" <andrey.warkentin@gmail.com>
Cc: 'Andrei Warkentin' <awarkentin@vmware.com>,
'Chris Ball' <cjb@laptop.org>,
linux-samsung-soc@vger.kernel.org,
'kgene kim' <kgene.kim@samsung.com>,
'dh han' <dh.han@samsung.com>,
linux-mmc@vger.kernel.org
Subject: RE: [PATCH] mmc: dw_mmc: Support predefined multiple block transfers.
Date: Wed, 28 Sep 2011 17:23:47 +0900 [thread overview]
Message-ID: <003101cc7db7$f203e350$d60ba9f0$%jun@samsung.com> (raw)
In-Reply-To: <CANz0V+7xJF4h4XUGoL43odFyOpwcBmxgV18R-uR4oDaqV-9jJA@mail.gmail.com>
Andrei Warkentin wrote:
> 2011/9/26 Seungwon Jeon <tgih.jun@samsung.com>:
> > Andrei Warkentin wrote:
> >> Hi Seungwon,
> >>
> >> ----- Original Message -----
> >> > From: "Seungwon Jeon" <tgih.jun@samsung.com>
> >> > To: linux-mmc@vger.kernel.org
> >> > Cc: "Chris Ball" <cjb@laptop.org>, linux-samsung-soc@vger.kernel.org,
> >> "kgene kim" <kgene.kim@samsung.com>, "dh han"
> >> > <dh.han@samsung.com>, "Seungwon Jeon" <tgih.jun@samsung.com>
> >> > Sent: Monday, September 26, 2011 7:46:59 AM
> >> > Subject: [PATCH] mmc: dw_mmc: Support predefined multiple block
> >> transfers.
> >> >
> >> > This patch adds the support for predefined multiple block read/write.
> >> >
> >> > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> >>
> >> Without knowing much about dw_mmc host, your logic otherwise looks ok,
> >> given what
> >> I've previously done for SDHCI as far as CMD23/Auto-CMD23 enhancement.
> >> Just curious, what eMMC cards did you test this on, and what
> improvement
> >> did you see?
> >
> > Thank you for review.
> > As you done, predefined transfer is required for reliable writes and
> eMMC4.5 feature.
> > Sadly, I didn't gain an improvement in my case.
> > (I don't know whether I can clarify the tested eMMC card, just one
> sample.)
> >
>
> So far I've seen some Sandisk cards have a noticeable real-life
> improvement (30%) over
> open-ended transfers.
>
> You might wish to try out https://github.com/andreiw/superalign to be
> certain.
I had already tested this patch with IOZONE, but I found no difference.
Maybe a result depends on eMMC device.
As your recommend, I applied above benchmark tool.
Predefined transfer seems like a little better, but there is no difference.
Thanks.
Seungwon Jeon.
>
> A
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-28 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 11:46 [PATCH] mmc: dw_mmc: Support predefined multiple block transfers Seungwon Jeon
2011-09-26 16:35 ` Andrei Warkentin
2011-09-27 2:12 ` Seungwon Jeon
2011-09-27 4:58 ` Andrei E. Warkentin
2011-09-28 8:23 ` Seungwon Jeon [this message]
2011-10-05 5:02 ` Jaehoon Chung
2011-10-05 8:02 ` Seungwon Jeon
2011-10-05 8:19 ` Jaehoon Chung
-- strict thread matches above, loose matches on Subject: below --
2011-09-26 9:15 Seungwon Jeon
2011-09-28 1:20 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003101cc7db7$f203e350$d60ba9f0$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=andrey.warkentin@gmail.com \
--cc=awarkentin@vmware.com \
--cc=cjb@laptop.org \
--cc=dh.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox