RE: [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor autoloading feature

Shilimkar, Santosh
2010-05-06T07:49:37Z

> -----Original Message-----
> From: Chikkature Rajashekar, Madhusudhan
> Sent: Wednesday, May 05, 2010 10:51 PM
> To: S, Venkatraman; Shilimkar, Santosh
> Cc: linux-omap@vger.kernel.org; linux-mmc@vger.kernel.org; linux-arm-kernel@lists.arm.linux.org.uk;
> 'Adrian Hunter'; Kadiyala, Kishore; 'Tony Lindgren'
> Subject: RE: [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor autoloading feature
>
> <snip>
>
> > >> +     if (cpu_is_omap44xx() || cpu_is_omap3630()) {
> > > Can we avoid above by passing this part of platform data??
> > > devices.c
> >
> > I am not clear about the method. The board files export the
> > omap_mmc_platform_data.
> > Does it imply that all board files have to change and export
> > the capability so that it can be queried ?
> >
>
> I don’t see why this capability needs to be passed from the platform data.
> As this feature is dependant on omap it is okay to have a cpu check in the
> driver as the patch is doing it.
>
Because Descriptor load feature is not MMC IP capability but SDMA capability.
To make MMC driver portable we should avoid cluttering with CPU specific checks.

This is recommended way unless and until you think otherwise.

Regards,
Santosh