[PATCH 04/22] mmc: bfin_sdh: remove unnecessary platform_set_drvdata()

[PATCH 04/22] mmc: bfin_sdh: remove unnecessary platform_set_drvdata()

[Jingoo Han]

The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/mmc/host/bfin_sdh.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c
index fb4348c..94fae2f 100644
--- a/drivers/mmc/host/bfin_sdh.c
+++ b/drivers/mmc/host/bfin_sdh.c
@@ -621,8 +621,6 @@ static int sdh_remove(struct platform_device *pdev)
 {
 	struct mmc_host *mmc = platform_get_drvdata(pdev);
 
-	platform_set_drvdata(pdev, NULL);
-
 	if (mmc) {
 		struct sdh_host *host = mmc_priv(mmc);
 
-- 
1.7.2.5

RE: [PATCH 04/22] mmc: bfin_sdh: remove unnecessary platform_set_drvdata()

[Zhang, Sonic]

Acked-by: Sonic Zhang <sonic.zhang@analog.com>

>-----Original Message-----
>From: Jingoo Han [mailto:jg1.han@samsung.com]
>Sent: Monday, May 06, 2013 2:12 PM
>To: 'Chris Ball'
>Cc: linux-mmc@vger.kernel.org; Jingoo Han; Zhang, Sonic
>Subject: [PATCH 04/22] mmc: bfin_sdh: remove unnecessary
>platform_set_drvdata()
>
>The driver core clears the driver data to NULL after device_release or on probe
>failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
>(device-core: Ensure drvdata = NULL when no driver is bound).
>Thus, it is not needed to manually clear the device driver data to NULL.
>
>Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>---
> drivers/mmc/host/bfin_sdh.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c index
>fb4348c..94fae2f 100644
>--- a/drivers/mmc/host/bfin_sdh.c
>+++ b/drivers/mmc/host/bfin_sdh.c
>@@ -621,8 +621,6 @@ static int sdh_remove(struct platform_device *pdev)  {
>       struct mmc_host *mmc = platform_get_drvdata(pdev);
>
>-      platform_set_drvdata(pdev, NULL);
>-
>       if (mmc) {
>               struct sdh_host *host = mmc_priv(mmc);
>
>--
>1.7.2.5
>
>

Re: [PATCH 04/22] mmc: bfin_sdh: remove unnecessary platform_set_drvdata()

[Jingoo Han]

On Monday, May 06, 2013 3:21 PM, Zhang, Sonic wrote:
> 
> Acked-by: Sonic Zhang <sonic.zhang@analog.com>

Thank you for your Acked-by. :)

Best regards,
Jingoo Han

> 
> >-----Original Message-----
> >From: Jingoo Han [mailto:jg1.han@samsung.com]
> >Sent: Monday, May 06, 2013 2:12 PM
> >To: 'Chris Ball'
> >Cc: linux-mmc@vger.kernel.org; Jingoo Han; Zhang, Sonic
> >Subject: [PATCH 04/22] mmc: bfin_sdh: remove unnecessary
> >platform_set_drvdata()
> >
> >The driver core clears the driver data to NULL after device_release or on probe
> >failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> >(device-core: Ensure drvdata = NULL when no driver is bound).
> >Thus, it is not needed to manually clear the device driver data to NULL.
> >
> >Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >---
> > drivers/mmc/host/bfin_sdh.c |    2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c index
> >fb4348c..94fae2f 100644
> >--- a/drivers/mmc/host/bfin_sdh.c
> >+++ b/drivers/mmc/host/bfin_sdh.c
> >@@ -621,8 +621,6 @@ static int sdh_remove(struct platform_device *pdev)  {
> >       struct mmc_host *mmc = platform_get_drvdata(pdev);
> >
> >-      platform_set_drvdata(pdev, NULL);
> >-
> >       if (mmc) {
> >               struct sdh_host *host = mmc_priv(mmc);
> >
> >--
> >1.7.2.5
> >
> >