* [PATCH 06/22] mmc: dw_mmc: remove unnecessary platform_set_drvdata()
@ 2013-05-06 6:16 Jingoo Han
2013-05-06 12:09 ` Seungwon Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 6:16 UTC (permalink / raw)
To: 'Chris Ball'
Cc: linux-mmc, Jingoo Han, 'Seungwon Jeon',
'Jaehoon Chung', 'Andy Shevchenko'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mmc/host/dw_mmc-pltfm.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c
index 41c27b7..37873f1 100644
--- a/drivers/mmc/host/dw_mmc-pltfm.c
+++ b/drivers/mmc/host/dw_mmc-pltfm.c
@@ -72,7 +72,6 @@ static int dw_mci_pltfm_remove(struct platform_device *pdev)
{
struct dw_mci *host = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
dw_mci_remove(host);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 06/22] mmc: dw_mmc: remove unnecessary platform_set_drvdata()
2013-05-06 6:16 [PATCH 06/22] mmc: dw_mmc: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 12:09 ` Seungwon Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Seungwon Jeon @ 2013-05-06 12:09 UTC (permalink / raw)
To: 'Jingoo Han', 'Chris Ball'
Cc: linux-mmc, 'Jaehoon Chung', 'Andy Shevchenko'
On Monday, May 06, 2013, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-06 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 6:16 [PATCH 06/22] mmc: dw_mmc: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 12:09 ` Seungwon Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox