* [PATCH 10/22] mmc: mxs-mmc: remove unnecessary platform_set_drvdata()
@ 2013-05-06 6:22 Jingoo Han
2013-05-06 8:49 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 6:22 UTC (permalink / raw)
To: 'Chris Ball'
Cc: linux-mmc, Jingoo Han, 'Marc Kleine-Budde', Shawn Guo
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mmc/host/mxs-mmc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index 4278a17..d38f0da 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -708,8 +708,6 @@ static int mxs_mmc_remove(struct platform_device *pdev)
mmc_remove_host(mmc);
- platform_set_drvdata(pdev, NULL);
-
if (ssp->dmach)
dma_release_channel(ssp->dmach);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 10/22] mmc: mxs-mmc: remove unnecessary platform_set_drvdata()
2013-05-06 6:22 [PATCH 10/22] mmc: mxs-mmc: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 8:49 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2013-05-06 8:49 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Chris Ball', linux-mmc, 'Marc Kleine-Budde'
On Mon, May 06, 2013 at 03:22:51PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/mmc/host/mxs-mmc.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 4278a17..d38f0da 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -708,8 +708,6 @@ static int mxs_mmc_remove(struct platform_device *pdev)
>
> mmc_remove_host(mmc);
>
> - platform_set_drvdata(pdev, NULL);
> -
> if (ssp->dmach)
> dma_release_channel(ssp->dmach);
>
> --
> 1.7.2.5
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-06 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 6:22 [PATCH 10/22] mmc: mxs-mmc: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 8:49 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox