* [PATCH 17/22] mmc: sdhci-pxa: remove unnecessary platform_set_drvdata()
@ 2013-05-06 6:34 Jingoo Han
2013-05-07 1:50 ` Haojian Zhuang
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 6:34 UTC (permalink / raw)
To: 'Chris Ball'
Cc: linux-mmc, Jingoo Han, Haojian Zhuang, 'Kevin Liu'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mmc/host/sdhci-pxav2.c | 2 --
drivers/mmc/host/sdhci-pxav3.c | 2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav2.c b/drivers/mmc/host/sdhci-pxav2.c
index 6a3f702..98b5145 100644
--- a/drivers/mmc/host/sdhci-pxav2.c
+++ b/drivers/mmc/host/sdhci-pxav2.c
@@ -253,8 +253,6 @@ static int sdhci_pxav2_remove(struct platform_device *pdev)
sdhci_pltfm_free(pdev);
kfree(pxa);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 1ae358e..90ee262 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -339,8 +339,6 @@ static int sdhci_pxav3_remove(struct platform_device *pdev)
sdhci_pltfm_free(pdev);
kfree(pxa);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 17/22] mmc: sdhci-pxa: remove unnecessary platform_set_drvdata()
2013-05-06 6:34 [PATCH 17/22] mmc: sdhci-pxa: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 1:50 ` Haojian Zhuang
0 siblings, 0 replies; 2+ messages in thread
From: Haojian Zhuang @ 2013-05-07 1:50 UTC (permalink / raw)
To: Jingoo Han; +Cc: Chris Ball, linux-mmc, Kevin Liu
On Mon, May 6, 2013 at 2:34 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mmc/host/sdhci-pxav2.c | 2 --
> drivers/mmc/host/sdhci-pxav3.c | 2 --
> 2 files changed, 0 insertions(+), 4 deletions(-)
>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 1:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 6:34 [PATCH 17/22] mmc: sdhci-pxa: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 1:50 ` Haojian Zhuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox