* [PATCH 18/22] mmc: sdhci-s3c: remove unnecessary platform_set_drvdata()
@ 2013-05-06 6:35 Jingoo Han
2013-05-07 3:37 ` Jaehoon Chung
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 6:35 UTC (permalink / raw)
To: 'Chris Ball'
Cc: linux-mmc, Jingoo Han, 'Ben Dooks', Jaehoon Chung
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mmc/host/sdhci-s3c.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index c6f6246..926aaf6 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -745,7 +745,6 @@ static int sdhci_s3c_remove(struct platform_device *pdev)
clk_disable_unprepare(sc->clk_io);
sdhci_free_host(host);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 18/22] mmc: sdhci-s3c: remove unnecessary platform_set_drvdata()
2013-05-06 6:35 [PATCH 18/22] mmc: sdhci-s3c: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 3:37 ` Jaehoon Chung
0 siblings, 0 replies; 2+ messages in thread
From: Jaehoon Chung @ 2013-05-07 3:37 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Chris Ball', linux-mmc, 'Ben Dooks',
Jaehoon Chung
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 05/06/2013 03:35 PM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mmc/host/sdhci-s3c.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index c6f6246..926aaf6 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -745,7 +745,6 @@ static int sdhci_s3c_remove(struct platform_device *pdev)
> clk_disable_unprepare(sc->clk_io);
>
> sdhci_free_host(host);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 3:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 6:35 [PATCH 18/22] mmc: sdhci-s3c: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 3:37 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox