* [PATCH 2/3] mmc: dw_mmc: correct mishandling error interrupt
@ 2012-08-01 0:30 Seungwon Jeon
2012-08-08 3:19 ` Chris Ball
0 siblings, 1 reply; 2+ messages in thread
From: Seungwon Jeon @ 2012-08-01 0:30 UTC (permalink / raw)
To: linux-mmc
Cc: 'Chris Ball', 'Will Newton',
'James Hogan', 'Jaehoon Chung'
Datasheet of SYNOPSYS mentions that DTO(Data Transfer Over) interrupt
will be raised even if some error interrupts, however it is actually
found that DTO does not occur. SYNOPSYS has confirmed this issue.
Current implementation defers the call of tasklet_schedule until DTO
when the error interrupts is happened. This patch fixes error handling.
Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 7baed45..1a5db20 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1580,9 +1580,7 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id)
host->data_status = pending;
smp_wmb();
set_bit(EVENT_DATA_ERROR, &host->pending_events);
- if (!(pending & (SDMMC_INT_DTO | SDMMC_INT_DCRC |
- SDMMC_INT_SBE | SDMMC_INT_EBE)))
- tasklet_schedule(&host->tasklet);
+ tasklet_schedule(&host->tasklet);
}
if (pending & SDMMC_INT_DATA_OVER) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/3] mmc: dw_mmc: correct mishandling error interrupt
2012-08-01 0:30 [PATCH 2/3] mmc: dw_mmc: correct mishandling error interrupt Seungwon Jeon
@ 2012-08-08 3:19 ` Chris Ball
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2012-08-08 3:19 UTC (permalink / raw)
To: Seungwon Jeon
Cc: linux-mmc, 'Will Newton', 'James Hogan',
'Jaehoon Chung'
Hi,
On Tue, Jul 31 2012, Seungwon Jeon wrote:
> Datasheet of SYNOPSYS mentions that DTO(Data Transfer Over) interrupt
> will be raised even if some error interrupts, however it is actually
> found that DTO does not occur. SYNOPSYS has confirmed this issue.
> Current implementation defers the call of tasklet_schedule until DTO
> when the error interrupts is happened. This patch fixes error handling.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 7baed45..1a5db20 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1580,9 +1580,7 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id)
> host->data_status = pending;
> smp_wmb();
> set_bit(EVENT_DATA_ERROR, &host->pending_events);
> - if (!(pending & (SDMMC_INT_DTO | SDMMC_INT_DCRC |
> - SDMMC_INT_SBE | SDMMC_INT_EBE)))
> - tasklet_schedule(&host->tasklet);
> + tasklet_schedule(&host->tasklet);
> }
>
> if (pending & SDMMC_INT_DATA_OVER) {
Thanks, pushed to mmc-next for 3.7.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-08 3:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-01 0:30 [PATCH 2/3] mmc: dw_mmc: correct mishandling error interrupt Seungwon Jeon
2012-08-08 3:19 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).