RE: [PATCH v2 1/4] mmc: dw_mmc: fix the transmission handling in IDMAC

Seungwon Jeon
2012-05-23T06:26:50Z

Hi, Jaehoon Chung,

We have missed Hyeonsu's patch?
I checked the your link page and found the similarity of patch now.
How can we do?
Anyway, it'd need to be applied.

Thanks,
Seungwon Jeon
Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi Seungwon,
>
> This patch is already sent from Hyeonsu Kim,
> Plz check the below patch.
> Add Hyeonsu to CC'd
>
> http://comments.gmane.org/gmane.linux.kernel.mmc/12870
>
> Best Regards,
> Jaehoon Chung
>
> On 05/22/2012 01:00 PM, Seungwon Jeon wrote:
>
> > DTO interrupt can be later than transmit interrupt(IDMAC)
> > in case of write. Current handling of idmac interrupt sets
> > EVENT_DATA_COMPLETE as well as EVENT_XFER_COMPLETE regardless
> > DTO rising. This makes the current request be finished in tasklet
> > and permits the next request even though current data transfer
> > is still in progress. As a result, sequence is broken and lock-up
> > happens. Setting EVENT_DATA_COMPLETE is not proper after IDMAC
> > interrupt. It should be taken after DTO interrupt is generated.
> >
> > Reported-by: Dmitry Shmidt <dimitrysh@android.com>
> > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> > ---
> > drivers/mmc/host/dw_mmc.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> > index 9bbf45f..b46faf0 100644
> > --- a/drivers/mmc/host/dw_mmc.c
> > +++ b/drivers/mmc/host/dw_mmc.c
> > @@ -1623,7 +1623,6 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id)
> > if (pending & (SDMMC_IDMAC_INT_TI | SDMMC_IDMAC_INT_RI)) {
> > mci_writel(host, IDSTS, SDMMC_IDMAC_INT_TI | SDMMC_IDMAC_INT_RI);
> > mci_writel(host, IDSTS, SDMMC_IDMAC_INT_NI);
> > - set_bit(EVENT_DATA_COMPLETE, &host->pending_events);
> > host->dma_ops->complete(host);
> > }
> > #endif
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html