From: Seungwon Jeon <tgih.jun@samsung.com>
To: merez@codeaurora.org
Cc: linux-mmc@vger.kernel.org, 'Chris Ball' <cjb@laptop.org>,
'Subhash Jadavani' <subhashj@codeaurora.org>,
"'S, Venkatraman'" <svenkatr@ti.com>,
'Saugata Das' <saugata.das@linaro.org>,
'Namjae Jeon' <linkinjeon@gmail.com>
Subject: RE: [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device
Date: Mon, 09 Jul 2012 19:13:03 +0900 [thread overview]
Message-ID: <00c401cd5dbb$6d605630$48210290$%jun@samsung.com> (raw)
In-Reply-To: <fc9caa907c442ce8390e774744d9dae7.squirrel@www.codeaurora.org>
Monday, July 09, 2012, Maya <merez@codeaurora.org> wrote:
> On Sun, July 8, 2012 4:52 pm, Seungwon Jeon wrote:
> > Sunday, July 08, 2012, Maya <merez@codeaurora.org> wrote:
> >> One minor comment below:
> >>
> >> > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue
> >> *mq, struct request *rqc)
> >> > (card->ext_csd.data_sector_size == 4096)) {
> >> You can use mmc_large_sec here (instead of
> >> card->ext_csd.data_sector_size
> >> == 4096)
> > Yes, but this line is kept due to another issue related with 4KB sector.
> >
> > Thanks,
> > Seungwon Jeon
> Hi,
>
> I'm not sure I understand your reply. mmc_large_sec does exactly what the
> if here does.
> My suggestion is to replace the code with the new function you added.
> I agree it's an old code but this way the code will be consistent and
> mmc_large_sec will be used in every place we would like to check if the
> sector size is 4K.
I just remained. The code you pointed can be replaced.
Regardless this review, I'll rework.
eMMC 4.51 spec was updated in June and there is some changes.
Spec mentions packed header is 8 blocks in 4KB native device.
I'll apply this change.
Thanks,
Seungwon Jeon
>
> Thanks,
> Maya
>
> --
> Sent by consultant of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-09 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 12:12 [PATCH v8 2/2] mmc: support packed write command for eMMC4.5 device merez
2012-07-08 23:52 ` Seungwon Jeon
2012-07-09 7:01 ` merez
2012-07-09 10:13 ` Seungwon Jeon [this message]
2012-07-10 5:40 ` merez
2012-07-10 5:48 ` merez
2012-11-04 5:05 ` merez
2012-11-14 2:54 ` Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2012-11-14 8:14 merez
2012-11-15 10:05 ` Seungwon Jeon
2012-06-29 4:33 Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00c401cd5dbb$6d605630$48210290$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=cjb@laptop.org \
--cc=linkinjeon@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=saugata.das@linaro.org \
--cc=subhashj@codeaurora.org \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox