* [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE
@ 2012-10-30 22:21 Sergei Trofimovich
2012-10-31 4:33 ` Jaehoon Chung
2012-11-01 10:07 ` Seungwon Jeon
0 siblings, 2 replies; 3+ messages in thread
From: Sergei Trofimovich @ 2012-10-30 22:21 UTC (permalink / raw)
To: Chris Ball
Cc: Sergei Trofimovich, Thomas Abraham, Will Newton, linux-mmc,
linux-kernel
From: Sergei Trofimovich <slyfox@gentoo.org>
Found by gcc:
linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1: error: '__mod_of_device_table' aliased to undefined symbol 'dw_mci_pltfm_match'
CC: Chris Ball <cjb@laptop.org>
CC: Thomas Abraham <thomas.abraham@linaro.org>
CC: Will Newton <will.newton@imgtec.com>
CC: linux-mmc@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
drivers/mmc/host/dw_mmc-exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 660bbc5..0147ac3a 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -223,7 +223,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
.data = (void *)&exynos5250_drv_data, },
{},
};
-MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
+MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
int dw_mci_exynos_probe(struct platform_device *pdev)
{
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE
2012-10-30 22:21 [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE Sergei Trofimovich
@ 2012-10-31 4:33 ` Jaehoon Chung
2012-11-01 10:07 ` Seungwon Jeon
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2012-10-31 4:33 UTC (permalink / raw)
To: Sergei Trofimovich
Cc: Chris Ball, Sergei Trofimovich, Thomas Abraham, Will Newton,
linux-mmc, linux-kernel
Looks good to me.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 10/31/2012 07:21 AM, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <slyfox@gentoo.org>
>
> Found by gcc:
>
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1: error: '__mod_of_device_table' aliased to undefined symbol 'dw_mci_pltfm_match'
>
> CC: Chris Ball <cjb@laptop.org>
> CC: Thomas Abraham <thomas.abraham@linaro.org>
> CC: Will Newton <will.newton@imgtec.com>
> CC: linux-mmc@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 660bbc5..0147ac3a 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -223,7 +223,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
> .data = (void *)&exynos5250_drv_data, },
> {},
> };
> -MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
> +MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
>
> int dw_mci_exynos_probe(struct platform_device *pdev)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE
2012-10-30 22:21 [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE Sergei Trofimovich
2012-10-31 4:33 ` Jaehoon Chung
@ 2012-11-01 10:07 ` Seungwon Jeon
1 sibling, 0 replies; 3+ messages in thread
From: Seungwon Jeon @ 2012-11-01 10:07 UTC (permalink / raw)
To: 'Sergei Trofimovich', 'Chris Ball'
Cc: 'Sergei Trofimovich', 'Thomas Abraham',
'Will Newton', linux-mmc, linux-kernel
On Wednesday, October 31, 2012, Sergei Trofimovich <slyfox@gentoo.org> wrote:
> From: Sergei Trofimovich <slyfox@gentoo.org>
>
> Found by gcc:
>
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1: error: '__mod_of_device_table' aliased to
> undefined symbol 'dw_mci_pltfm_match'
>
> CC: Chris Ball <cjb@laptop.org>
> CC: Thomas Abraham <thomas.abraham@linaro.org>
> CC: Will Newton <will.newton@imgtec.com>
> CC: linux-mmc@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
I suggest changing the prefix of subject.
'mmc: dw_mmc-exynos' instead of 'exynos: mmc'
Thanks,
Seungwon Jeon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-01 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-30 22:21 [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE Sergei Trofimovich
2012-10-31 4:33 ` Jaehoon Chung
2012-11-01 10:07 ` Seungwon Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox