From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: satyajit.sahu@amd.com, ssundark@amd.com, craigb@chromium.org,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-pci: Only do AMD tuning for HS200
Date: Tue, 10 Apr 2018 10:21:06 +0530 [thread overview]
Message-ID: <02cf09ac-2390-2d80-a77c-b79c21783664@amd.com> (raw)
In-Reply-To: <20180406220806.150534-1-djkurtz@chromium.org>
On 4/7/2018 3:37 AM, Daniel Kurtz wrote:
> Commit c31165d7400b ("mmc: sdhci-pci: Add support for HS200 tuning mode
> on AMD, eMMC-4.5.1") added a HS200 tuning method for use with AMD SDHCI
> controllers. As described in the commit subject, this tuning is specific
> for HS200. However, as implemented, this method is used for all host
> timings, because platform_execute_tuning, if it exists, is called
> unconditionally by sdhci_execute_tuning(). This breaks tuning when using
> the AMD controller with, for example, a DDR50 SD card.
>
> Instead, we can implement an amd execute_tuning wrapper callback, and
> then conditionally do the HS200 specific tuning for HS200, and otherwise
> call back to the standard sdhci_execute_tuning().
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Looks good.
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
next prev parent reply other threads:[~2018-04-10 4:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 22:07 [PATCH] mmc: sdhci-pci: Only do AMD tuning for HS200 Daniel Kurtz
2018-04-10 4:51 ` Shyam Sundar S K [this message]
2018-04-10 11:53 ` Adrian Hunter
2018-04-11 14:52 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cf09ac-2390-2d80-a77c-b79c21783664@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=adrian.hunter@intel.com \
--cc=craigb@chromium.org \
--cc=djkurtz@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=satyajit.sahu@amd.com \
--cc=ssundark@amd.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox