From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-mmc@vger.kernel.org, ian.molton@codethink.co.uk,
chris@printf.net, ulf.hansson@linaro.org
Cc: linux-sh@vger.kernel.org
Subject: [PATCH v4] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()
Date: Thu, 18 Sep 2014 23:33:49 +0400 [thread overview]
Message-ID: <10228473.uOqbQ0oioV@wasted.cogentembedded.com> (raw)
I spent a couple of days with the driver just hanging due to me forgetting to
specify the external crystal frequency, so that clk_get_rate() returned 0 and
thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an
acceptable behavior, so I suggest that the minimum frequency is checked for 0
in tmio_mmc_host_probe().
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Ian Molton <ian.molton@codethink.co.uk>
Cc: stable@vger.kernel.org
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch.
Changes in version 4:
- rebased to the 'next' branch, resolving reject;
- added Ian Molton's ACK.
Changes in version 3:
- added Cc: stable.
Changes in version 2:
- fixed grammar in the changelog.
drivers/mmc/host/tmio_mmc_pio.c | 9 +++++++++
1 file changed, 9 insertions(+)
Index: mmc/drivers/mmc/host/tmio_mmc_pio.c
===================================================================
--- mmc.orig/drivers/mmc/host/tmio_mmc_pio.c
+++ mmc/drivers/mmc/host/tmio_mmc_pio.c
@@ -1091,6 +1091,15 @@ int tmio_mmc_host_probe(struct tmio_mmc_
}
/*
+ * Check the sanity of mmc->f_min to prevent tmio_mmc_set_clock() from
+ * looping forever...
+ */
+ if (mmc->f_min == 0) {
+ ret = -EINVAL;
+ goto host_free;
+ }
+
+ /*
* While using internal tmio hardware logic for card detection, we need
* to ensure it stays powered for it to work.
*/
next reply other threads:[~2014-09-18 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 19:33 Sergei Shtylyov [this message]
2014-09-19 18:46 ` [PATCH v4] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock() Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10228473.uOqbQ0oioV@wasted.cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=chris@printf.net \
--cc=ian.molton@codethink.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox