From: Arnd Bergmann <arnd@arndb.de>
To: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
ulf.hansson@linaro.org, nicolas.ferre@atmel.com,
chris@printf.net
Subject: Re: [PATCH 2/3] mmc: atmel-mci: stop using specific initcall
Date: Thu, 20 Nov 2014 16:25:15 +0100 [thread overview]
Message-ID: <10252473.yMqnOBQJ48@wuerfel> (raw)
In-Reply-To: <20141120141855.GJ3639@ldesroches-Latitude-E6320>
On Thursday 20 November 2014 15:18:55 Ludovic Desroches wrote:
> On Thu, Nov 20, 2014 at 03:13:30PM +0100, Arnd Bergmann wrote:
> > On Thursday 20 November 2014 15:01:25 Ludovic Desroches wrote:
> > > On Thu, Nov 20, 2014 at 12:10:25PM +0100, Arnd Bergmann wrote:
> > > > On Thursday 20 November 2014 11:07:54 Ludovic Desroches wrote:
> > > > > No more use late initcall to manage probing order. Use probe deferring
> > > > > if needed. Then use module_platform_driver and clean init/exit
> > > > > attributes.
> > > > >
> > > > > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> > > > >
> > > >
> > > > Do we need this backported into stable kernels? It seems that
> > > > the __init/__exit annotations will break things if you ever
> > > > tried to unbind the device or run into deferred probing on
> > > > earlier kernels.
> > >
> > > Well, it is a bit complicated, if we backport it, then the mci driver
> > > could be probed before the dma controller. Requesting dma chan will fail
> > > and it will switch to pio mode.
> > >
> > > So it has to be backported with the probe deferring. The issue is
> > > that probe deferring patch is based on other patches removing non-dt
> > > support which become useless only ine 3.19.
> > >
> >
> > Should we just have the __init/__exit removal in backports then?
>
> Yes. Do you want me to split this patch in order to have ony one for
> __init/__exit removal and another one for late_initcall removal?
>
>
Yes, I think that would be best.
Arnd
next prev parent reply other threads:[~2014-11-20 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 10:07 [PATCH 1/3] mmc: atmel-mci: remove useless DMA stuff for non-dt devices Ludovic Desroches
2014-11-20 10:07 ` [PATCH 2/3] mmc: atmel-mci: stop using specific initcall Ludovic Desroches
2014-11-20 11:10 ` Arnd Bergmann
2014-11-20 14:01 ` Ludovic Desroches
2014-11-20 14:13 ` Arnd Bergmann
2014-11-20 14:18 ` Ludovic Desroches
2014-11-20 15:25 ` Arnd Bergmann [this message]
2014-11-20 10:07 ` [PATCH 3/3] mmc: atmel-mci: use probe deferring if dma controller is not ready yet Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10252473.yMqnOBQJ48@wuerfel \
--to=arnd@arndb.de \
--cc=chris@printf.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox