From: Arnd Bergmann <arnd@arndb.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
dmaengine@vger.kernel.org, alsa-devel@alsa-project.org,
linux-mmc@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH, RFC] MIPS: jz4740: use dma filter function
Date: Wed, 07 Jan 2015 17:13:44 +0100 [thread overview]
Message-ID: <10623722.YrKe6DgiSS@wuerfel> (raw)
In-Reply-To: <54AD42D0.4070402@metafoo.de>
On Wednesday 07 January 2015 15:29:36 Lars-Peter Clausen wrote:
> On 01/06/2015 02:48 PM, Arnd Bergmann wrote:
> > On Tuesday 06 January 2015 11:45:58 Lars-Peter Clausen wrote:
> >> On 01/05/2015 11:39 PM, Arnd Bergmann wrote:
> >>> As discussed on the topic of shmobile DMA today, jz4740 is the only
> >>> user of the slave_id field in dma_slave_config besides shmobile. This
> >>> use is really incompatible with the way that other drivers use the
> >>> dmaengine API, so we should get rid of it.
> >>
> >> Do you have a link to that discussion?
> >
> > http://www.spinics.net/lists/linux-mmc/msg30069.html
>
> I'm really not comfortable with this patch, since it is a step back. But I
> guess the end justify the means. So if it helps to get rid of slave_id I'm
> ok with it, sooner or later jz4740 will be converted to DT so once that's
> done the filter function can be removed again. But please put the filter
> function in a non arch specific header so we can still compile test things.
> And maybe note in the commit message that this is meant as a temporary hack.
>
Do you have a timeline for DT support? Maybe it's easier to just
wait for the problem to solve itself.
Arnd
next prev parent reply other threads:[~2015-01-07 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 22:39 [PATCH, RFC] MIPS: jz4740: use dma filter function Arnd Bergmann
2015-01-06 10:45 ` Lars-Peter Clausen
2015-01-06 12:47 ` Måns Rullgård
2015-01-06 12:51 ` Lars-Peter Clausen
2015-01-06 13:48 ` Arnd Bergmann
2015-01-07 14:29 ` Lars-Peter Clausen
2015-01-07 16:13 ` Arnd Bergmann [this message]
2015-01-07 16:17 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10623722.YrKe6DgiSS@wuerfel \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox