From: Arnd Bergmann <arnd@arndb.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Jonas Jensen <jonas.jensen@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH v3] mmc: moxart: fix probe logic
Date: Tue, 03 Feb 2015 10:06:51 +0100 [thread overview]
Message-ID: <11355014.PH1MhDAcRs@wuerfel> (raw)
In-Reply-To: <CAPDyKFoppJBHx4nio111GM9RPv8pkfm4yZg2+AedLjnSZhmFsg@mail.gmail.com>
On Tuesday 03 February 2015 09:02:22 Ulf Hansson wrote:
> > @@ -586,10 +588,11 @@ static int moxart_probe(struct platform_device *pdev)
> > goto out;
> > }
> >
> > - clk = of_clk_get(node, 0);
>
> This code would be simpler using devm_clk_get(), since then error
> wouldn't be needed.
>
> Any reason to why you don't want to use that?
You are absolutely right, and that would have avoided both of the bugs
I introduced.
Arnd
prev parent reply other threads:[~2015-02-03 9:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 16:15 [PATCH] mmc: moxart: fix probe logic Arnd Bergmann
2015-01-29 17:01 ` Russell King - ARM Linux
2015-01-29 22:04 ` Arnd Bergmann
2015-01-29 22:06 ` [PATCH v2] " Arnd Bergmann
2015-02-02 10:52 ` Jonas Jensen
2015-02-02 14:58 ` Arnd Bergmann
2015-02-02 15:43 ` [PATCH v3] " Jonas Jensen
2015-02-02 20:03 ` Arnd Bergmann
2015-02-03 15:55 ` [PATCH v4] " Jonas Jensen
2015-02-04 8:40 ` Ulf Hansson
2015-02-03 8:02 ` [PATCH v3] " Ulf Hansson
2015-02-03 9:06 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11355014.PH1MhDAcRs@wuerfel \
--to=arnd@arndb.de \
--cc=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox