From: Daniel Drake <dsd@laptop.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: akpm@linux-foundation.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] sdio: Fix crash in mmc_attach_sdio() error path
Date: Tue, 01 Dec 2009 16:00:29 +0000 [thread overview]
Message-ID: <1259683229.2124.35.camel@localhost.localdomain> (raw)
In-Reply-To: <20091201155325.GB21413@console-pimps.org>
On Tue, 2009-12-01 at 15:53 +0000, Matt Fleming wrote:
> I don't understand what you're trying to do here. The card->sdio_funcs++
> should take care of incrementing the sdio_funcs count properly. When the
> loop terminates both "i" and "card->sdio_funcs" will be equal to
> "funcs", unless we jump to the remove label. Unless I've missed
> something?
Sorry, that was indeed a small mistake.
> Isn't this hunk below fixing a slightly different bug? Admittedly, it
> could cause a crash, but I think it warrants a separate patch and
> changelog.
>
> I assumed you would be sending a patch just for this bug below and not
> for the one above (which I is why I submitted one). I wasn't very clear
> about that though ;-)
OK, I'll resend that part alone.
Thanks,
Daniel
prev parent reply other threads:[~2009-12-01 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 15:13 [PATCH] sdio: Fix crash in mmc_attach_sdio() error path Daniel Drake
2009-12-01 15:53 ` Matt Fleming
2009-12-01 16:00 ` Daniel Drake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259683229.2124.35.camel@localhost.localdomain \
--to=dsd@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox