From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Philip Langdale <philipl@overt.org>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Pierre Ossman <pierre@ossman.eu>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH v3] port ricoh_mmc to pci quirk
Date: Sat, 30 Jan 2010 00:10:33 +0200 [thread overview]
Message-ID: <1264803033.7095.4.camel@maxim-laptop> (raw)
In-Reply-To: <20100129080639.3b484a59@fido2.homeip.net>
On Fri, 2010-01-29 at 08:06 -0800, Philip Langdale wrote:
> On Fri, 29 Jan 2010 15:37:35 +0200
> Maxim Levitsky <maximlevitsky@gmail.com> wrote:
>
> > Here, updated patch with your comments addressed.
> > This is also tested with real MMC card.
>
> Actual code gets my thumbs up.
>
> > This adds some > 80 chars lines, but I hope that is ok.
>
> It's against the coding style and as far as I can see, the only
> lines that are > 80 are the dev_notice and DECLARE_FIXUP lines - both
> of which can be trivially split across multiple lines, so please just
> do that.
Well, I have nothing against this, but, even Linus himself stated that
he dislikes broken printk lines.
I also noticed that some DECLARE_FIXUP in this file are longer that 80,
and since breaking this doesn't add any value, I thought that is ok.
Remember that main purpose of 80 char limit is to make code simpler.
However, I don't really care if you insist.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2010-01-29 22:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1259021583.16650.9.camel@maxim-laptop>
[not found] ` <20091123162119.3777e14d@fido2.homeip.net>
[not found] ` <1259160947.10147.1.camel@maxim-laptop>
[not found] ` <1259161121.10147.4.camel@maxim-laptop>
[not found] ` <20091125085324.1ef9ae1f@fido2.homeip.net>
[not found] ` <20091125113501.1f4d42b9.akpm@linux-foundation.org>
[not found] ` <1259192401.15916.48.camel@maxim-laptop>
[not found] ` <20091125173019.74d0ddb9@fido2.homeip.net>
[not found] ` <1259279520.3991.5.camel@maxim-laptop>
[not found] ` <1259279584.3991.6.camel@maxim-laptop>
[not found] ` <20091126235551.2db699e3@fido2.homeip.net>
[not found] ` <1262964284.12577.27.camel@maxim-laptop>
[not found] ` <20100108074001.5df6c997@fido2.homeip.net>
2010-01-12 23:43 ` [PATCH v2] port ricoh_mmc to be pci quirk Andrew Morton
2010-01-13 1:23 ` Philip Langdale
2010-01-13 6:46 ` Wolfram Sang
2010-01-29 13:37 ` [PATCH v3] port ricoh_mmc to " Maxim Levitsky
2010-01-29 16:06 ` Philip Langdale
2010-01-29 22:10 ` Maxim Levitsky [this message]
2010-01-30 2:18 ` Philip Langdale
2010-01-29 16:33 ` Wolfram Sang
2010-01-29 22:13 ` Maxim Levitsky
2010-01-30 21:28 ` [PATCH] Port " Maxim Levitsky
2010-02-01 15:45 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264803033.7095.4.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=philipl@overt.org \
--cc=pierre@ossman.eu \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox