Re: [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend

David Vrabel
2010-02-10T11:31:27Z

Nicolas Pitre wrote:
> From: Daniel Drake <dsd@laptop.org>
>
> And bring them back to 4-bit mode during resume.

Why? Is this for a specific card that doesn't support asynchronous card
interrupts while in 4-bit mode? If so, I'd suggest a card quirk for
this and only switch modes for these cards.

> + ctrl |= SDIO_BUS_ASYNC_INT;

This bit is for SPI mode only. Why are you setting it here?

David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/

Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom