Re: [PATCH v2] Enable DMA for Ricoh reader on Lenovo laptops

Maxim Levitsky
2010-02-15T15:58:30Z

On Mon, 2010-02-15 at 11:49 +0200, Vasily Khoruzhick wrote:
> В сообщении от 15 февраля 2010 01:20:52 автор Maxim Levitsky написал:
>
> > Acer Aspire 5720.
>
> So my patch with quirk addition for Lenovo will not work for you. Maybe it'll
> be better to enable DMA by default on all Ricoh readers?
>
> Regards,
> Vasily

Yep, works for me.

I used this:

@@ -87,6 +87,8 @@ static int ricoh_probe(struct sdhci_pci_chip *chip)
chip->pdev->subsystem_vendor == PCI_VENDOR_ID_SONY)
chip->quirks |= SDHCI_QUIRK_NO_CARD_NO_RESET;

+ chip->quirks |= SDHCI_QUIRK_CLOCK_BEFORE_RESET;
+ chip->quirks |= SDHCI_QUIRK_FORCE_DMA;
return 0;
}

Not sure if I need the SDHCI_QUIRK_CLOCK_BEFORE_RESET.

What I don't get is why DMA capability isn't advertised?

Since xD and memstick portions do support DMA, I can't belive that they
don't use DMA in SD/SDHCI portion.

Ah, I forgot that SDHCI is handled by microsoft driver.... Maybe it
doesn't test the DMA bits.

If we were to follow the way MS driver works, we wouldn't need the
quirks, right?

Best regards,
Maxim Levitsky