From: <gregkh@suse.de>
To: lars@metafoo.de, akpm@linux-foundation.org, ben-linux@fluff.org,
gregkh@suse.de, linux-mmc@vger.kernel.org,
torvalds@linux-foundation.org
Cc: stable@kernel.org, stable-commits@vger.kernel.org
Subject: patch s3cmci-initialize-default-platform-data-no_wprotect-and-no_detect-with-1.patch added to 2.6.32-stable tree
Date: Thu, 11 Mar 2010 16:47:27 -0800 [thread overview]
Message-ID: <1268354847532@site> (raw)
This is a note to let you know that we have just queued up the patch titled
Subject: s3cmci: initialize default platform data no_wprotect and no_detect with 1
to the 2.6.32-stable tree. Its filename is
s3cmci-initialize-default-platform-data-no_wprotect-and-no_detect-with-1.patch
A git repo of this tree can be found at
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>From c212808a1ba6bfba489006399b8152a047305acf Mon Sep 17 00:00:00 2001
From: Lars-Peter Clausen <lars@metafoo.de>
Date: Fri, 5 Mar 2010 13:43:35 -0800
Subject: s3cmci: initialize default platform data no_wprotect and no_detect with 1
From: Lars-Peter Clausen <lars@metafoo.de>
commit c212808a1ba6bfba489006399b8152a047305acf upstream.
If no platform_data was givin to the device it's going to use it's default
platform data struct which has all fields initialized to zero. As a
result the driver is going to try to request gpio0 both as write protect
and card detect pin. Which of course will fail and makes the driver
unusable
Previously to the introduction of no_wprotect and no_detect the behavior
was to assume that if no platform data was given there is no write protect
or card detect pin. This patch restores that behavior.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1360,6 +1360,8 @@ static struct mmc_host_ops s3cmci_ops = {
static struct s3c24xx_mci_pdata s3cmci_def_pdata = {
/* This is currently here to avoid a number of if (host->pdata)
* checks. Any zero fields to ensure reasonable defaults are picked. */
+ .no_wprotect = 1,
+ .no_detect = 1,
};
#ifdef CONFIG_CPU_FREQ
Patches currently in stable-queue which might be from lars@metafoo.de are
next reply other threads:[~2010-03-12 2:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 0:47 gregkh [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-30 21:57 patch s3cmci-initialize-default-platform-data-no_wprotect-and-no_detect-with-1.patch added to 2.6.32-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268354847532@site \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=lars@metafoo.de \
--cc=linux-mmc@vger.kernel.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).