* [PATCH] mmc: sd: Cleanup redundant memset
@ 2010-04-09 3:15 Mark Asselstine
0 siblings, 0 replies; only message in thread
From: Mark Asselstine @ 2010-04-09 3:15 UTC (permalink / raw)
To: kernel-janitors, akpm, linux-mmc; +Cc: asselsm
The clearing of mrq via a memset at the top of the for loop in
mmc_wait_for_app_cmd() is not required as mrq is not used and
there is another clearing of mrq just below. We remove the first
memset since if the initial tests in the for loop fail the memset
is not required.
Signed-off-by: Mark Asselstine <asselsm@gmail.com>
---
Resending to linux-mmc@vger.kernel.org and akpm@linux-foundation.org
since MMC/SD is an orphan so hopefully including these folks will allow
someone to pick this patch up.
drivers/mmc/core/sd_ops.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
index 0d96080..63772e7 100644
--- a/drivers/mmc/core/sd_ops.c
+++ b/drivers/mmc/core/sd_ops.c
@@ -79,8 +79,6 @@ int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
* we cannot use the retries field in mmc_command.
*/
for (i = 0;i <= retries;i++) {
- memset(&mrq, 0, sizeof(struct mmc_request));
-
err = mmc_app_cmd(host, card);
if (err) {
/* no point in retrying; no APP commands allowed */
--
1.7.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-09 3:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-09 3:15 [PATCH] mmc: sd: Cleanup redundant memset Mark Asselstine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).