From: James Bottomley <James.Bottomley@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Robert Hancock <hancockrwd@gmail.com>,
"Gao, Yunpeng" <yunpeng.gao@intel.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: How to make kernel block layer generate bigger request in the request queue?
Date: Sat, 10 Apr 2010 09:58:23 -0500 [thread overview]
Message-ID: <1270911503.2806.194.camel@mulgrave.site> (raw)
In-Reply-To: <yq1y6gwt62p.fsf@sermon.lab.mkp.net>
On Fri, 2010-04-09 at 22:05 -0400, Martin K. Petersen wrote:
> >>>>> "Robert" == Robert Hancock <hancockrwd@gmail.com> writes:
>
> >> Did I miss something to make the block layer generate bigger size
> >> data for every request in the request queue? Below is part of my
> >> source code. Any comments are highly appreciated. Thank you in
> >> advance.
>
> Robert> 8 sectors is 4KB, that's the size of a page. If the pages that
> Robert> are being written are not physically contiguous that may be the
> Robert> best the block layer can do with the constraints you've given it
> Robert> (not supporting any more than 1 DMA segment).
>
> Correct. It's quite unlikely for pages to be contiguous so this is the
> best we can do.
Actually, average servers do about 50% contiguous on average since we
changed the mm layer to allocate in ascending physical page order ...
this figure is highly sensitive to mm changes though, and can vary from
release to release.
Just in case anyone is thinking of it, there's no way we'd alter the
block layer to copy into physically contiguous since the overhead would
be pretty horrific. However, if the platform has an iommu, you can use
it to map physically discontinuous to bus contiguous and fit everything
into a single sg element.
> Having recently done a cleanup of our segment handling I became aware
> that there are many MMC devices that are single-element only. This was
> probably a sufficient approach for 32MB devices but it's time to get
> with the program and implement proper scatter-gather.
James
next prev parent reply other threads:[~2010-04-10 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 14:07 How to make kernel block layer generate bigger request in the request queue? Gao, Yunpeng
2010-04-09 23:54 ` Robert Hancock
2010-04-10 2:05 ` Martin K. Petersen
2010-04-10 14:58 ` James Bottomley [this message]
2010-04-12 18:26 ` Martin K. Petersen
2010-04-12 19:58 ` James Bottomley
2010-04-13 15:06 ` Gao, Yunpeng
2010-04-13 15:20 ` Alan Cox
2010-04-19 6:42 ` Gao, Yunpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270911503.2806.194.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox