From: Ben Hutchings <ben@decadent.org.uk>
To: Matt Fleming <matt@console-pimps.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
linux-mmc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Dooks <ben-linux@fluff.org>,
Yunpeng Gao <yunpeng.gao@intel.com>
Subject: Re: [PATCH 1/2] mmc: Add helper function to check if a card is removable
Date: Sat, 28 Aug 2010 15:13:09 +0100 [thread overview]
Message-ID: <1283004789.7653.76.camel@localhost> (raw)
In-Reply-To: <4d1a88f196fa7e7eaf4c4a4af13d91ec81fb084e.1283003070.git.matt@console-pimps.org>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Sat, 2010-08-28 at 14:53 +0100, Matt Fleming wrote:
[...]
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -272,5 +272,12 @@ static inline void mmc_set_disable_delay(struct mmc_host *host,
> host->disable_delay = disable_delay;
> }
>
> +extern int mmc_assume_removable;
This variable is already declared in drivers/mmc/core/core.h. Either
remove the declaration from there or define the following function there
instead of here.
> +static inline int mmc_card_is_removable(struct mmc_host *host)
> +{
> + return (!(host->caps & MMC_CAP_NONREMOVABLE) || mmc_assume_removable);
> +}
> +
That '||' should be an '&&'.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2010-08-28 14:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 6:34 [PATCH] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case Jaehoon Chung
2010-08-27 7:09 ` Matt Fleming
2010-08-27 7:14 ` Kyungmin Park
2010-08-27 11:55 ` Gao, Yunpeng
2010-08-28 13:37 ` Matt Fleming
2010-08-28 13:53 ` [PATCH 1/2] mmc: Add helper function to check if a card is removable Matt Fleming
2010-08-28 13:53 ` [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case Matt Fleming
2010-08-30 1:06 ` Kyungmin Park
2010-09-02 8:51 ` Jaehoon Chung
2010-09-02 9:14 ` Matt Fleming
2010-09-08 1:27 ` Jaehoon Chung
2010-09-15 15:11 ` Matt Fleming
2010-09-15 15:14 ` Matt Fleming
2010-09-15 20:38 ` Chris Ball
2010-09-16 2:20 ` Chris Ball
2010-09-16 9:02 ` Matt Fleming
2010-09-26 7:31 ` zhangfei gao
2010-09-27 8:43 ` Matt Fleming
2010-08-28 14:13 ` Ben Hutchings [this message]
2010-08-28 14:28 ` [PATCH 1/2] mmc: Add helper function to check if a card is removable Matt Fleming
2010-08-30 9:59 ` [PATCH v2] " Matt Fleming
2010-09-02 8:48 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283004789.7653.76.camel@localhost \
--to=ben@decadent.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matt@console-pimps.org \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox