* [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation
@ 2016-02-10 14:07 Chris Paterson
2016-02-10 14:33 ` Ulf Hansson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Paterson @ 2016-02-10 14:07 UTC (permalink / raw)
To: ulf.hansson
Cc: linux-mmc, linux-kernel, kuninori.morimoto.gx, ykaneko0929, arnd,
geert+renesas, laurent.pinchart, kouichi.tomita.yn,
takeshi.kihara.df, koji.matsuoka.xm, Chris Paterson
Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
introduced a typo causing the TX DMA channel allocation to be overwritten
by the requested RX DMA channel.
Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
---
drivers/mmc/host/sh_mmcif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index e0c076a..8d870ce 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -445,7 +445,7 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host *host)
pdata->slave_id_rx);
} else {
host->chan_tx = dma_request_slave_channel(dev, "tx");
- host->chan_tx = dma_request_slave_channel(dev, "rx");
+ host->chan_rx = dma_request_slave_channel(dev, "rx");
}
dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
host->chan_rx);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation
2016-02-10 14:07 [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Chris Paterson
@ 2016-02-10 14:33 ` Ulf Hansson
2016-02-10 14:36 ` Laurent Pinchart
2016-02-10 14:45 ` Arnd Bergmann
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2016-02-10 14:33 UTC (permalink / raw)
To: Chris Paterson
Cc: linux-mmc, linux-kernel@vger.kernel.org, Kuninori Morimoto,
Yoshihiro Kaneko, Arnd Bergmann, Geert Uytterhoeven,
Laurent Pinchart, Kouichi Tomita, takeshi.kihara.df,
koji.matsuoka.xm
On 10 February 2016 at 15:07, Chris Paterson
<chris.paterson2@renesas.com> wrote:
> Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
> introduced a typo causing the TX DMA channel allocation to be overwritten
> by the requested RX DMA channel.
>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Thanks, applied for fixes and I also added a corresponding fixes tag.
Kind regards
Uffe
> ---
> drivers/mmc/host/sh_mmcif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index e0c076a..8d870ce 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -445,7 +445,7 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host *host)
> pdata->slave_id_rx);
> } else {
> host->chan_tx = dma_request_slave_channel(dev, "tx");
> - host->chan_tx = dma_request_slave_channel(dev, "rx");
> + host->chan_rx = dma_request_slave_channel(dev, "rx");
> }
> dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
> host->chan_rx);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation
2016-02-10 14:07 [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Chris Paterson
2016-02-10 14:33 ` Ulf Hansson
@ 2016-02-10 14:36 ` Laurent Pinchart
2016-02-10 14:45 ` Arnd Bergmann
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2016-02-10 14:36 UTC (permalink / raw)
To: Chris Paterson
Cc: ulf.hansson, linux-mmc, linux-kernel, kuninori.morimoto.gx,
ykaneko0929, arnd, geert+renesas, kouichi.tomita.yn,
takeshi.kihara.df, koji.matsuoka.xm
Hi Chris,
Thank you for the patch.
On Wednesday 10 February 2016 14:07:01 Chris Paterson wrote:
> Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
> introduced a typo causing the TX DMA channel allocation to be overwritten
> by the requested RX DMA channel.
>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/mmc/host/sh_mmcif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index e0c076a..8d870ce 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -445,7 +445,7 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host
> *host) pdata->slave_id_rx);
> } else {
> host->chan_tx = dma_request_slave_channel(dev, "tx");
> - host->chan_tx = dma_request_slave_channel(dev, "rx");
> + host->chan_rx = dma_request_slave_channel(dev, "rx");
> }
> dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
> host->chan_rx);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation
2016-02-10 14:07 [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Chris Paterson
2016-02-10 14:33 ` Ulf Hansson
2016-02-10 14:36 ` Laurent Pinchart
@ 2016-02-10 14:45 ` Arnd Bergmann
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-02-10 14:45 UTC (permalink / raw)
To: Chris Paterson
Cc: ulf.hansson, linux-mmc, linux-kernel, kuninori.morimoto.gx,
ykaneko0929, geert+renesas, laurent.pinchart, kouichi.tomita.yn,
takeshi.kihara.df, koji.matsuoka.xm
On Wednesday 10 February 2016 14:07:01 Chris Paterson wrote:
> Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
> introduced a typo causing the TX DMA channel allocation to be overwritten
> by the requested RX DMA channel.
>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> ---
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Sorry about the trouble.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-10 14:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 14:07 [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Chris Paterson
2016-02-10 14:33 ` Ulf Hansson
2016-02-10 14:36 ` Laurent Pinchart
2016-02-10 14:45 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox