From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Levitsky Subject: Re: [PATCH] sdio: fix suspend/resume regression Date: Fri, 22 Oct 2010 02:25:11 +0200 Message-ID: <1287707111.12734.30.camel@maxim-laptop> References: <1286788315.3101.11.camel@sven> <1286955116-22793-1-git-send-email-ohad@wizery.com> <1287704855.12734.14.camel@maxim-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:50372 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175Ab0JVAZO (ORCPT ); Thu, 21 Oct 2010 20:25:14 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Nicolas Pitre Cc: Ohad Ben-Cohen , linux-mmc@vger.kernel.org, Sven Neumann , Chris Ball , libertas-dev@lists.infradead.org, "Rafael J. Wysocki" , Daniel Mack , Colin Cross , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@kernel.org On Thu, 2010-10-21 at 19:55 -0400, Nicolas Pitre wrote: > On Fri, 22 Oct 2010, Maxim Levitsky wrote: > > > So what happens if you set .suspend to NULL? instead of -ENOSYS return? > > At run time, the driver may decide to handle the suspend request and > return 0, or decide to simply return -ENOSYS if it doesn't want to > bother with the suspend meaning that the card should be removed, or > return another error code meaning that the suspend request must be > aborted. I am afraid that this is very hard to support. If .suspend would be called from pm notifier, it would create problems last time I checked. Or maybe it won't? I will test that again, as it might be very nice solution. I could even just call the mmc_suspend_host from the pm notifier. Best regards, Maxim Levitsky