From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Chris Ball <cjb@laptop.org>, Oliver Neukum <oneukum@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: Fix re-probing after hibernation
Date: Thu, 09 Dec 2010 00:04:52 +0200 [thread overview]
Message-ID: <1291845892.5421.2.camel@maxim-laptop> (raw)
In-Reply-To: <1291821839-15088-1-git-send-email-tiwai@suse.de>
On Wed, 2010-12-08 at 16:23 +0100, Takashi Iwai wrote:
> The commit 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e
> mmc: fix all hangs related to mmc/sd card insert/removal during
> suspend/resume
> introduced a bug where the device probing no longer works after
> hibernation. This was because the pm notifier expects
> PM_POST_HIBERNATION call while the system sends PM_POST_RESTORE
> instead, thus disable_rescan is kept as 1.
>
> Cc: <stable@kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> drivers/mmc/core/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 31ae07a..30094f6 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1772,7 +1772,7 @@ int mmc_pm_notify(struct notifier_block *notify_block,
> break;
>
> case PM_POST_SUSPEND:
> - case PM_POST_HIBERNATION:
> + case PM_POST_RESTORE:
>
> spin_lock_irqsave(&host->lock, flags);
> host->rescan_disable = 0;
So that was the case....
Takasi, thank you very much.
I always use the 'unsafe resume' thing so I wasn't affected.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2010-12-08 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 15:23 [PATCH] mmc: Fix re-probing after hibernation Takashi Iwai
2010-12-08 22:04 ` Maxim Levitsky [this message]
2010-12-09 1:53 ` Chris Ball
[not found] ` <s5hlj3z1ksb.wl%tiwai@suse.de>
2010-12-09 20:37 ` Rafael J. Wysocki
2010-12-10 7:40 ` Takashi Iwai
2010-12-11 21:55 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291845892.5421.2.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox