From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Levitsky Subject: Re: [PATCH] mmc: Fix re-probing after hibernation Date: Thu, 09 Dec 2010 00:04:52 +0200 Message-ID: <1291845892.5421.2.camel@maxim-laptop> References: <1291821839-15088-1-git-send-email-tiwai@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f45.google.com ([209.85.214.45]:65230 "EHLO mail-bw0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289Ab0LHWE6 (ORCPT ); Wed, 8 Dec 2010 17:04:58 -0500 In-Reply-To: <1291821839-15088-1-git-send-email-tiwai@suse.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Takashi Iwai Cc: Chris Ball , Oliver Neukum , Andrew Morton , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 2010-12-08 at 16:23 +0100, Takashi Iwai wrote: > The commit 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e > mmc: fix all hangs related to mmc/sd card insert/removal during > suspend/resume > introduced a bug where the device probing no longer works after > hibernation. This was because the pm notifier expects > PM_POST_HIBERNATION call while the system sends PM_POST_RESTORE > instead, thus disable_rescan is kept as 1. > > Cc: > Signed-off-by: Takashi Iwai > --- > drivers/mmc/core/core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index 31ae07a..30094f6 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -1772,7 +1772,7 @@ int mmc_pm_notify(struct notifier_block *notify_block, > break; > > case PM_POST_SUSPEND: > - case PM_POST_HIBERNATION: > + case PM_POST_RESTORE: > > spin_lock_irqsave(&host->lock, flags); > host->rescan_disable = 0; So that was the case.... Takasi, thank you very much. I always use the 'unsafe resume' thing so I wasn't affected. Best regards, Maxim Levitsky