From: Richard Zhu <r65037@freescale.com>
To: r58066@freescale.com, root@udp161639uds.ap.freescale.net
Cc: lnxrevli@freescale.com, Richard Zhu <r65037@freescale.com>,
linux-mmc@vger.kernel.org
Subject: [REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP
Date: Tue, 11 Jan 2011 10:02:48 +0800 [thread overview]
Message-ID: <1294711368-446-1-git-send-email-r65037@freescale.com> (raw)
Pick up the patch from the community.
fc8a0985c2846292312556cba10b8a4182f55967
From: Hanumath Prasad <hanumath.prasad@stericsson.com>
Date: Tue, 10 Aug 2010 18:01:45 -0700
Subject: [REVIEW 2/2] mmc: only set blockaddressed for > 2GiB cards
A non-zero value of SEC_COUNT does not indicate that the card is sector
addressed. According to the MMC specification, cards
with a densitygreater than 2GiB are sector addressed.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Hanumath Prasad <hanumath.prasad@stericsson.com>
Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Richard Zhu <r65037@freescale.com>
drivers/mmc/core/mmc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP
sha : ce733e353d0ac82c9a607b708f7de2b214408445
local branch is : imx_2.6.35
remote_branch : origin/imx_2.6.35
branch_start : v2.6.35.3
review-commits last updated 2010-12-31 13:49 /home/r65037/bin/linux-infra/tools/review-commits
d33ca02dca1624e86b1513e7bb7cce7281cd9590 don't generate pkg for linux-2.6-testbu
ild for cherry-pick experiment
git version 1.6.3.3
Running checkpatch.pl:
total: 0 errors, 0 warnings, 10 lines checked
Your patch has no obvious style problems and is ready for submission.
checking header of ce733e3: ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP
check header: PASS
Checking kernel paths: PASS
review-commits: PASS
=============================================
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 4a9e2ed..95e13c2 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -222,7 +222,9 @@ static int mmc_read_ext_csd(struct mmc_card *card)
ext_csd[EXT_CSD_SEC_CNT + 1] << 8 |
ext_csd[EXT_CSD_SEC_CNT + 2] << 16 |
ext_csd[EXT_CSD_SEC_CNT + 3] << 24;
- if (card->ext_csd.sectors)
+
+ /* Cards with density > 2GiB are sector addressed */
+ if (card->ext_csd.sectors > (2u * 1024 * 1024 * 1024) / 512)
mmc_card_set_blockaddr(card);
}
--
1.6.3.3
next reply other threads:[~2011-01-11 2:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 2:02 Richard Zhu [this message]
2011-01-11 2:07 ` [REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP Chris Ball
[not found] ` <1.10.2011-mgd.freescale.com-30-6343028328831767454500-3831@freescale.com>
2011-01-11 2:17 ` Re:[lnxrevli] [REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards can't workwell " Zhu Richard-R65037
2011-01-11 2:22 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294711368-446-1-git-send-email-r65037@freescale.com \
--to=r65037@freescale.com \
--cc=linux-mmc@vger.kernel.org \
--cc=lnxrevli@freescale.com \
--cc=r58066@freescale.com \
--cc=root@udp161639uds.ap.freescale.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox