From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Olech Subject: Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission Date: Mon, 24 Jan 2011 08:49:06 +0000 Message-ID: <1295858946.1677.3.camel@apple-mac> References: <20B0EAA71DD7413A9A29D0493C6C1D87@AN00536> <20101116150022.GA27726@void.printf.net> <27884BED0E3C489C8849EE12A803F536@AN00536> <4CE41BE3.1060806@elandigitalsystems.com> <4CEA86D4.9050109@elandigitalsystems.com> <1295607004.1816.6.camel@apple-mac> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.126.171]:54380 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181Ab1AXItS (ORCPT ); Mon, 24 Jan 2011 03:49:18 -0500 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Nicolas Pitre Cc: Chris Ball , linux-mmc@vger.kernel.org, David Vrabel On Fri, 2011-01-21 at 16:14 -0500, Nicolas Pitre wrote: > On Fri, 21 Jan 2011, Tony Olech wrote: > > There are 5 "do not initialise statics" errors reported by scripts/checkpatch.pl > > you probably should fix those. They are due to lines such as: > > static int pad_input_to_usb_pkt = 0; > static int disable_offload_processing = 0; > static int force_1_bit_data_xfers = 0; > static int force_polling_for_irqs = 0; > > Since those are global variables, you may omit to initialize them to 0 > which would then allocate them to the .bss section which is not included > in the compiled binary, and automatically cleared to zero at run time > Nicolas Yes they are due to exactly that, BUT I have a great aversion to using uninitialized variables. How can initializing all one's variables be considered a bug???? Tony Olech > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html