From: Sahitya Tummala <stummala@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mmc@vger.kernel.org, San Mehat <san@google.com>,
"; linux-arm-msm"@vger.kernel.org
Subject: Re: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()
Date: Mon, 28 Feb 2011 17:58:17 +0530 [thread overview]
Message-ID: <1298896097.15439.7.camel@stummala-linux.in.qualcomm.com> (raw)
In-Reply-To: <AANLkTikju_TmJpPceg0BNvfGx1w1yuNUZcqcSc1ttLhv@mail.gmail.com>
On Sat, 2011-02-26 at 13:01 +0100, Linus Walleij wrote:
> On Wed, Feb 16, 2011 at 11:28 PM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>
> > dma_unmap_sg() already flushes the cache, I don't get what this
> > code is doing here.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Any feedback on this? I'd prefer the maintainer(s) Acked-by,
> but the patch is pretty clear as it stands I believe and I will
> request Chris to include it anyway, intuitively it is correct.
Hi Linus Walleij,
You are right. This patch looks good.
--
Thanks,
Sahitya.
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
next prev parent reply other threads:[~2011-02-28 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 22:28 [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg() Linus Walleij
2011-02-26 12:01 ` Linus Walleij
2011-02-28 12:28 ` Sahitya Tummala [this message]
2011-02-28 12:34 ` Sahitya Tummala
2011-02-28 15:54 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298896097.15439.7.camel@stummala-linux.in.qualcomm.com \
--to=stummala@codeaurora.org \
--cc="; linux-arm-msm"@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=san@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox