From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sahitya Tummala Subject: Re: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg() Date: Mon, 28 Feb 2011 17:58:17 +0530 Message-ID: <1298896097.15439.7.camel@stummala-linux.in.qualcomm.com> References: <1297895333-5551-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:30313 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753789Ab1B1M20 (ORCPT ); Mon, 28 Feb 2011 07:28:26 -0500 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Linus Walleij Cc: linux-mmc@vger.kernel.org, San Mehat , "; linux-arm-msm"@vger.kernel.org On Sat, 2011-02-26 at 13:01 +0100, Linus Walleij wrote: > On Wed, Feb 16, 2011 at 11:28 PM, Linus Walleij > wrote: > > > dma_unmap_sg() already flushes the cache, I don't get what this > > code is doing here. > > > > Signed-off-by: Linus Walleij > > Any feedback on this? I'd prefer the maintainer(s) Acked-by, > but the patch is pretty clear as it stands I believe and I will > request Chris to include it anyway, intuitively it is correct. Hi Linus Walleij, You are right. This patch looks good. -- Thanks, Sahitya. -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.