Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

[Tony Olech <tony.olech@elandigitalsystems.com>]

see embedded answers:-

On Tue, 2011-03-15 at 17:23 +0100, Arnd Bergmann wrote:
> On Thursday 10 March 2011, Tony Olech wrote:
> >   Add a driver for Elan Digital System's VUB300 chip
> > which is a USB connected SDIO/SDmem/MMC host controller.
> > A VUB300 chip enables a USB 2.0 or USB 1.1 connected host
> > computer to use SDIO/SD/MMC cards without the need for
> > a directly connected, for example via PCI, SDIO host
> > controller.
> First a small question: I've read that USB mmc controllers
> only work for SDIO but not for storage cards. Is that true
> for this driver?

The chip has been designed to handle memory cards as well
as SDIO, and we have test all we could get our hands on,
and tested for and thus 64M to 8G SD cards. It has also
been tested on a 64M MMC (1 bit) data card.

> If not, I'd probably get one for card testing, since the
> spring loading mechanism in my laptop is starting to wear
> out.
> What are typical products using this?

At the moment the dev kit, which is really just a bare board
USB to SD/SDIO/MMC converter, is available for evaluation.
the chips themselves are available for for purchase - see
our web site for details.

> My comments are mostly for coding style, I didn't see any
> major problems with the operation of the driver.

I am going to have to go through your coding style comments
separately.

Thanks for reading through the code,

Tony Olech