linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: linux-mmc@vger.kernel.org
Cc: Todd Poynor <toddpoynor@google.com>, Chris Ball <cjb@laptop.org>,
	Arnd Bergmann <arnd@arndb.de>, Dima Zavin <dima@android.com>,
	John Stultz <john.stultz@linaro.org>
Subject: [PATCH 3/6] sdhci: Always pass clock request value zero to set_clock host op
Date: Fri, 22 Apr 2011 18:01:39 -0700	[thread overview]
Message-ID: <1303520502-32171-4-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1303520502-32171-1-git-send-email-john.stultz@linaro.org>

From: Todd Poynor <toddpoynor@google.com>

To allow the set_clock host op to disable the SDCLK source when not
needed, always call the host op when the requested clock speed is
zero.  Do this even if host->clock already equals zero, because
the SDHCI driver may set that value (without calling the host op)
to force an update at the next (non-zero-speed) call.

CC: Chris Ball <cjb@laptop.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Dima Zavin <dima@android.com>
Change-Id: If99230d76138679b5767f77cb925f15408ae518e
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/mmc/host/sdhci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 9e15f41..3820adf 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -992,7 +992,7 @@ static void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
 	u16 clk;
 	unsigned long timeout;
 
-	if (clock == host->clock)
+	if (clock && clock == host->clock)
 		return;
 
 	if (host->ops->set_clock) {
-- 
1.7.3.2.146.gca209


  parent reply	other threads:[~2011-04-23  1:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-23  1:01 [PATCH 0/6] Trivial MMC patches from Android John Stultz
2011-04-23  1:01 ` [PATCH 1/6] mmc: block: Resume multi-block reads after transient read errors John Stultz
2011-04-26 13:19   ` Arnd Bergmann
2011-04-27  8:16     ` Adrian Hunter
2011-04-27  8:42       ` Andrei Warkentin
2011-04-23  1:01 ` [PATCH 2/6] mmc_block: Allow more than 8 partitions per card John Stultz
2011-04-26 13:22   ` Arnd Bergmann
2011-04-26 16:10     ` Colin Cross
2011-04-26 16:13       ` Arnd Bergmann
2011-04-23  1:01 ` John Stultz [this message]
2011-04-23  1:01 ` [PATCH 4/6] mmc: sd: Add new CONFIG_MMC_PARANOID_SD_INIT for enabling retries during SD detection John Stultz
2011-04-26 13:35   ` Arnd Bergmann
2011-04-23  1:01 ` [PATCH 5/6] mmc: sd: When resuming, try a little harder to init the card John Stultz
2011-04-26 13:39   ` Arnd Bergmann
2011-04-23  1:01 ` [PATCH 6/6] mmc: sd: Add retries in re-detection John Stultz
2011-04-26 13:42   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303520502-32171-4-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=arnd@arndb.de \
    --cc=cjb@laptop.org \
    --cc=dima@android.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).