[PATCH 00/15] Enable compilation of various Renesas drivers with COMPILE_TEST

[PATCH 00/15] Enable compilation of various Renesas drivers with COMPILE_TEST

[Laurent Pinchart]

Hello,

This patch series enables driver compilation with COMPILE_TEST for various
Renesas drivers. The approach taken here is to split the Kconfig depends line
in two, with compile dependencies (if any) on one line and runtime
dependencies (as a list of the platforms on which the hardware can be found)
on another line. The runtime dependencies line is extended with
|| COMPILE_TEST to enable test compilation. This clearly identifies compile
dependencies, and allow test compilation while not clobbering the
configuration menu with useless options in the normal case.

The patches are based on top of v3.13-rc1. To avoid build warnings or errors
during bisection the following patches sent to linux-sh and appropriate
mailing lists should be applied first:

serial: sh-sci: Fix warnings due to improper casts and printk formats
DMA: shdma: Fix warnings due to improper casts and printk formats
DMA: shdma: Fix warnings due to declared but unused symbols
DMA: shdma: Make sh_dmae_pm static
v4l: sh_vou: Fix warnings due to improper casts and printk formats
mmc: sh_mmcif: Factorize DMA channel request and configuration code
mmc: sh_mmcif: Fix compilation warning on 64-bit platforms
mtd: sh_flctl: Fix warnings due to improper casts
fbdev: sh_mobile_lcdcfb: Don't use plain 0 as NULL pointer
spi: sh-msiof: Fix warnings due to improper casts
spi: rcar: Fix uninitialized variable warning
spi: rcar: Fix pointer cast in the remove function

For convenience I've pushed the whole series and its prerequisites to my git
tree at

	git://linuxtv.org/pinchartl/fbdev.git clocks/ccf/multiarch-drivers

The patches will need to go through their respective subsystem's trees. To
help me tracking the mainlining state I'd appreciate if the respective
maintainers could notify me when applying the patches to their trees. Before
doing so I'd like to get an ack from Mark Brown and/or Russell King on the
approach.

Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
Cc: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Eduardo Valentin <eduardo.valentin-l0cyMroinI0@public.gmane.org>
Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Guennadi Liakhovetski <g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>
Cc: Ian Molton <ian-zdned+2MO1+9FHfhHBbuYA@public.gmane.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mauro Carvalho Chehab <m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Samuel Ortiz <samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>
Cc: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Laurent Pinchart (15):
  i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation
  input: sh_keysc: Restrict non-COMPILE_TEST compilation
  serial: sh-sci: Restrict non-COMPILE_TEST compilation
  iommu: shmobile: Enable driver compilation with COMPILE_TEST
  DMA: shdma: Enable driver compilation with COMPILE_TEST
  v4l: sh_vou: Enable driver compilation with COMPILE_TEST
  mmc: sdhi: Enable driver compilation with COMPILE_TEST
  mmc: sh_mmcif: Enable driver compilation with COMPILE_TEST
  mtd: sh_flctl: Enable driver compilation with COMPILE_TEST
  irda: sh_irda: Enable driver compilation with COMPILE_TEST
  pwm: pwm-renesas-tpu: Enable driver compilation with COMPILE_TEST
  thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST
  fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST
  spi: sh-msiof: Enable driver compilation with COMPILE_TEST
  sh: intc: Enable driver compilation with COMPILE_TEST

 drivers/dma/sh/Kconfig         | 2 +-
 drivers/i2c/busses/Kconfig     | 4 ++--
 drivers/input/keyboard/Kconfig | 2 +-
 drivers/iommu/Kconfig          | 1 +
 drivers/media/platform/Kconfig | 3 ++-
 drivers/mmc/host/Kconfig       | 6 ++++--
 drivers/mtd/nand/Kconfig       | 2 +-
 drivers/net/irda/Kconfig       | 3 ++-
 drivers/pwm/Kconfig            | 2 +-
 drivers/sh/intc/Kconfig        | 2 +-
 drivers/spi/Kconfig            | 3 ++-
 drivers/thermal/Kconfig        | 2 +-
 drivers/tty/serial/Kconfig     | 3 ++-
 drivers/video/Kconfig          | 8 +++++---
 14 files changed, 26 insertions(+), 17 deletions(-)

-- 
Regards,

Laurent Pinchart

[PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Laurent Pinchart]

This helps increasing build testing coverage.

The driver doesn't compile on (at least) x86 due (possibly among others)
to missing readsw/writesw I/O accessors, restrict compilation to SUPERH
or ARM.

Whether the CTL_DMA_ENABLE register is part of the standard TMIO
controller or is Renesas-specific is unknown and impossible to test as
we have no current or planned TMIO DMA users other than SUPERH and
ARCH_SHMOBILE. Writing to the register is thus conditionally compiled
for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the
list would extend this to multiarch kernels, but would break the driver
for non-shmobile platforms if the register is Renesas-specific. We can
thus get rid of the conditional compilation completely without
introducing any further issue, and let future non-Renesas users deal
with the situation if it turns out to be a the problem.

Cc: Chris Ball <cjb@laptop.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Ian Molton <ian@mnementh.co.uk>
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Simon Horman <horms@verge.net.au>
---
 drivers/mmc/host/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 7fc5099..ca1315e 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -479,7 +479,8 @@ config MMC_TMIO
 
 config MMC_SDHI
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select MMC_TMIO_CORE
 	help
 	  This provides support for the SDHI SD/SDIO controller found in
-- 
1.8.3.2

[PATCH 08/15] mmc: sh_mmcif: Enable driver compilation with COMPILE_TEST

[Laurent Pinchart]

This helps increasing build testing coverage.

Cc: Chris Ball <cjb@laptop.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Simon Horman <horms@verge.net.au>
---
 drivers/mmc/host/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index ca1315e..265ba48 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -589,7 +589,8 @@ config MMC_DW_PCI
 
 config MMC_SH_MMCIF
 	tristate "SuperH Internal MMCIF support"
-	depends on MMC_BLOCK && (SUPERH || ARCH_SHMOBILE)
+	depends on MMC_BLOCK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  This selects the MMC Host Interface controller (MMCIF).
 
-- 
1.8.3.2

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Laurent Pinchart]

Hi Chris,

Could you please pick this patch (and patch 08/15 in the same series) up for 
v3.14 ?

On Wednesday 27 November 2013 02:18:29 Laurent Pinchart wrote:
> This helps increasing build testing coverage.
> 
> The driver doesn't compile on (at least) x86 due (possibly among others)
> to missing readsw/writesw I/O accessors, restrict compilation to SUPERH
> or ARM.
> 
> Whether the CTL_DMA_ENABLE register is part of the standard TMIO
> controller or is Renesas-specific is unknown and impossible to test as
> we have no current or planned TMIO DMA users other than SUPERH and
> ARCH_SHMOBILE. Writing to the register is thus conditionally compiled
> for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the
> list would extend this to multiarch kernels, but would break the driver
> for non-shmobile platforms if the register is Renesas-specific. We can
> thus get rid of the conditional compilation completely without
> introducing any further issue, and let future non-Renesas users deal
> with the situation if it turns out to be a the problem.
> 
> Cc: Chris Ball <cjb@laptop.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Ian Molton <ian@mnementh.co.uk>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Simon Horman <horms@verge.net.au>
> ---
>  drivers/mmc/host/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 7fc5099..ca1315e 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -479,7 +479,8 @@ config MMC_TMIO
> 
>  config MMC_SDHI
>  	tristate "SH-Mobile SDHI SD/SDIO controller support"
> -	depends on SUPERH || ARCH_SHMOBILE
> +	depends on SUPERH || ARM
> +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
>  	select MMC_TMIO_CORE
>  	help
>  	  This provides support for the SDHI SD/SDIO controller found in
-- 
Regards,

Laurent Pinchart

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Sergei Shtylyov]

Hello.

On 27-11-2013 5:18, Laurent Pinchart wrote:

> This helps increasing build testing coverage.

> The driver doesn't compile on (at least) x86 due (possibly among others)
> to missing readsw/writesw I/O accessors, restrict compilation to SUPERH
> or ARM.

> Whether the CTL_DMA_ENABLE register is part of the standard TMIO
> controller or is Renesas-specific is unknown and impossible to test as
> we have no current or planned TMIO DMA users other than SUPERH and
> ARCH_SHMOBILE. Writing to the register is thus conditionally compiled
> for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the
> list would extend this to multiarch kernels, but would break the driver
> for non-shmobile platforms if the register is Renesas-specific. We can
> thus get rid of the conditional compilation completely without
> introducing any further issue, and let future non-Renesas users deal
> with the situation if it turns out to be a the problem.

> Cc: Chris Ball <cjb@laptop.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Ian Molton <ian@mnementh.co.uk>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Simon Horman <horms@verge.net.au>
> ---
>   drivers/mmc/host/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 7fc5099..ca1315e 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -479,7 +479,8 @@ config MMC_TMIO
>
>   config MMC_SDHI
>   	tristate "SH-Mobile SDHI SD/SDIO controller support"
> -	depends on SUPERH || ARCH_SHMOBILE
> +	depends on SUPERH || ARM
> +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST

    Hm, why 2 "depends" lines with SUPERH in both?

WBR, Sergei

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Laurent Pinchart]

On Wednesday 11 December 2013 22:01:53 Sergei Shtylyov wrote:
> Hello.
> 
> On 27-11-2013 5:18, Laurent Pinchart wrote:
> > This helps increasing build testing coverage.
> > 
> > The driver doesn't compile on (at least) x86 due (possibly among others)
> > to missing readsw/writesw I/O accessors, restrict compilation to SUPERH
> > or ARM.
> > 
> > Whether the CTL_DMA_ENABLE register is part of the standard TMIO
> > controller or is Renesas-specific is unknown and impossible to test as
> > we have no current or planned TMIO DMA users other than SUPERH and
> > ARCH_SHMOBILE. Writing to the register is thus conditionally compiled
> > for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the
> > list would extend this to multiarch kernels, but would break the driver
> > for non-shmobile platforms if the register is Renesas-specific. We can
> > thus get rid of the conditional compilation completely without
> > introducing any further issue, and let future non-Renesas users deal
> > with the situation if it turns out to be a the problem.
> > 
> > Cc: Chris Ball <cjb@laptop.org>
> > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > Cc: Ian Molton <ian@mnementh.co.uk>
> > Cc: linux-mmc@vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > Acked-by: Simon Horman <horms@verge.net.au>
> > ---
> > 
> >   drivers/mmc/host/Kconfig | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 7fc5099..ca1315e 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -479,7 +479,8 @@ config MMC_TMIO
> > 
> >   config MMC_SDHI
> >   
> >   	tristate "SH-Mobile SDHI SD/SDIO controller support"
> > 
> > -	depends on SUPERH || ARCH_SHMOBILE
> > +	depends on SUPERH || ARM
> > +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> 
>     Hm, why 2 "depends" lines with SUPERH in both?

The first line means "this driver requires SUPERH || ARM to be compiled", 
while the second line means "devices supported by this driver are only found 
on SUPERH || ARCH_SHMOBILE platforms".

-- 
Regards,

Laurent Pinchart

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Sergei Shtylyov]

On 11-12-2013 22:06, Laurent Pinchart wrote:

>>> This helps increasing build testing coverage.

>>> The driver doesn't compile on (at least) x86 due (possibly among others)
>>> to missing readsw/writesw I/O accessors, restrict compilation to SUPERH
>>> or ARM.

>>> Whether the CTL_DMA_ENABLE register is part of the standard TMIO
>>> controller or is Renesas-specific is unknown and impossible to test as
>>> we have no current or planned TMIO DMA users other than SUPERH and
>>> ARCH_SHMOBILE. Writing to the register is thus conditionally compiled
>>> for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the
>>> list would extend this to multiarch kernels, but would break the driver
>>> for non-shmobile platforms if the register is Renesas-specific. We can
>>> thus get rid of the conditional compilation completely without
>>> introducing any further issue, and let future non-Renesas users deal
>>> with the situation if it turns out to be a the problem.

>>> Cc: Chris Ball <cjb@laptop.org>
>>> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>> Cc: Ian Molton <ian@mnementh.co.uk>
>>> Cc: linux-mmc@vger.kernel.org
>>> Signed-off-by: Laurent Pinchart
>>> <laurent.pinchart+renesas@ideasonboard.com>
>>> Acked-by: Simon Horman <horms@verge.net.au>
[...]

>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>> index 7fc5099..ca1315e 100644
>>> --- a/drivers/mmc/host/Kconfig
>>> +++ b/drivers/mmc/host/Kconfig
>>> @@ -479,7 +479,8 @@ config MMC_TMIO
>>>
>>>    config MMC_SDHI
>>>
>>>    	tristate "SH-Mobile SDHI SD/SDIO controller support"
>>>
>>> -	depends on SUPERH || ARCH_SHMOBILE
>>> +	depends on SUPERH || ARM
>>> +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST

>>      Hm, why 2 "depends" lines with SUPERH in both?

> The first line means "this driver requires SUPERH || ARM to be compiled",

    Then COMPILE_TEST should be there, no?

> while the second line means "devices supported by this driver are only found
> on SUPERH || ARCH_SHMOBILE platforms".

WBR, Sergei

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Laurent Pinchart]

Hi Sergei,

On Wednesday 11 December 2013 22:22:19 Sergei Shtylyov wrote:
> On 11-12-2013 22:06, Laurent Pinchart wrote:
> >>> This helps increasing build testing coverage.
> >>> 
> >>> The driver doesn't compile on (at least) x86 due (possibly among others)
> >>> to missing readsw/writesw I/O accessors, restrict compilation to SUPERH
> >>> or ARM.
> >>> 
> >>> Whether the CTL_DMA_ENABLE register is part of the standard TMIO
> >>> controller or is Renesas-specific is unknown and impossible to test as
> >>> we have no current or planned TMIO DMA users other than SUPERH and
> >>> ARCH_SHMOBILE. Writing to the register is thus conditionally compiled
> >>> for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the
> >>> list would extend this to multiarch kernels, but would break the driver
> >>> for non-shmobile platforms if the register is Renesas-specific. We can
> >>> thus get rid of the conditional compilation completely without
> >>> introducing any further issue, and let future non-Renesas users deal
> >>> with the situation if it turns out to be a the problem.
> >>> 
> >>> Cc: Chris Ball <cjb@laptop.org>
> >>> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> >>> Cc: Ian Molton <ian@mnementh.co.uk>
> >>> Cc: linux-mmc@vger.kernel.org
> >>> Signed-off-by: Laurent Pinchart
> >>> <laurent.pinchart+renesas@ideasonboard.com>
> >>> Acked-by: Simon Horman <horms@verge.net.au>
> 
> [...]
> 
> >>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> >>> index 7fc5099..ca1315e 100644
> >>> --- a/drivers/mmc/host/Kconfig
> >>> +++ b/drivers/mmc/host/Kconfig
> >>> @@ -479,7 +479,8 @@ config MMC_TMIO
> >>> 
> >>>    config MMC_SDHI
> >>>    	tristate "SH-Mobile SDHI SD/SDIO controller support"
> >>> -	depends on SUPERH || ARCH_SHMOBILE
> >>> +	depends on SUPERH || ARM
> >>> +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> >>> 
> >>      Hm, why 2 "depends" lines with SUPERH in both?
> > 
> > The first line means "this driver requires SUPERH || ARM to be compiled",
> 
>     Then COMPILE_TEST should be there, no?

No, because the first line says that the driver is known *not* to compile on 
platforms other than ARM and SUPERH. Adding || COMPILE_TEST there would break 
compilation with allyesconfig and randconfig on those other platforms.

Stated differently, the first line restricts the driver from being compiled on 
architectures where it doesn't compile, regardless of COMPILE_TEST, and the 
second line restricts it to platform where hardware is known to exists, with 
COMPILE_TEST to optionally extend build coverage.

> > while the second line means "devices supported by this driver are only
> > found on SUPERH || ARCH_SHMOBILE platforms".

-- 
Regards,

Laurent Pinchart

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Laurent Pinchart]

Hi Chris,

On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote:
> Hi Chris,
> 
> Could you please pick this patch (and patch 08/15 in the same series) up for
> v3.14 ?

Ping ?

> On Wednesday 27 November 2013 02:18:29 Laurent Pinchart wrote:
> > This helps increasing build testing coverage.
> > 
> > The driver doesn't compile on (at least) x86 due (possibly among others)
> > to missing readsw/writesw I/O accessors, restrict compilation to SUPERH
> > or ARM.
> > 
> > Whether the CTL_DMA_ENABLE register is part of the standard TMIO
> > controller or is Renesas-specific is unknown and impossible to test as
> > we have no current or planned TMIO DMA users other than SUPERH and
> > ARCH_SHMOBILE. Writing to the register is thus conditionally compiled
> > for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the
> > list would extend this to multiarch kernels, but would break the driver
> > for non-shmobile platforms if the register is Renesas-specific. We can
> > thus get rid of the conditional compilation completely without
> > introducing any further issue, and let future non-Renesas users deal
> > with the situation if it turns out to be a the problem.
> > 
> > Cc: Chris Ball <cjb@laptop.org>
> > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > Cc: Ian Molton <ian@mnementh.co.uk>
> > Cc: linux-mmc@vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > Acked-by: Simon Horman <horms@verge.net.au>
> > ---
> > 
> >  drivers/mmc/host/Kconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 7fc5099..ca1315e 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -479,7 +479,8 @@ config MMC_TMIO
> > 
> >  config MMC_SDHI
> >  
> >  	tristate "SH-Mobile SDHI SD/SDIO controller support"
> > 
> > -	depends on SUPERH || ARCH_SHMOBILE
> > +	depends on SUPERH || ARM
> > +	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> > 
> >  	select MMC_TMIO_CORE
> >  	help
> >  	
> >  	  This provides support for the SDHI SD/SDIO controller found in
-- 
Regards,

Laurent Pinchart

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Chris Ball]

Hi Laurent,

On Tue, Jan 07 2014, Laurent Pinchart wrote:
> Hi Chris,
>
> On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote:
>> Hi Chris,
>> 
>> Could you please pick this patch (and patch 08/15 in the same series) up for
>> v3.14 ?
>
> Ping ?

Thanks, both pushed to mmc-next for 3.14, sorry for the delay.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

[Laurent Pinchart]

On Tuesday 07 January 2014 15:50:45 Chris Ball wrote:
> On Tue, Jan 07 2014, Laurent Pinchart wrote:
> > On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote:
> >> Hi Chris,
> >> 
> >> Could you please pick this patch (and patch 08/15 in the same series) up
> >> for v3.14 ?
> > 
> > Ping ?
> 
> Thanks, both pushed to mmc-next for 3.14, sorry for the delay.

No worries, thank you.

-- 
Regards,

Laurent Pinchart