Re: [PATCH 2/3] omap_hsmmc: add pm_caps field

Eliad Peller
2011-11-28T10:07:22Z

On Mon, Nov 28, 2011 at 12:01 PM, Igor Grinberg <grinberg@compulab.co.il> wrote:
> On 11/28/11 11:23, Eliad Peller wrote:
>> hi Igor,
>>
>> On Mon, Nov 28, 2011 at 11:15 AM, Igor Grinberg <grinberg@compulab.co.il> wrote:
>>> On 11/22/11 16:02, Eliad Peller wrote:
>>>> Add pm_caps field to omap2_hsmmc_info and omap_mmc_slot_data
>>>> structs, so we will be able to indicate mmc pm capabilities
>>>> in the board file.
>>>
>>> Shouldn't this be user space runtime controllable?
>>> Instead of being a static per board decision?
>>>
>> we only declare here support for the pm capabilities.
>> the actual configuration of these capabilities is done at a later
>> stage, and can be controlled (implicitly) by userspace (e.g. by
>> enabling Wakeup-On-Wireless for the wl12xx chip).
>
> This is good to hear, because patch 1/3 makes it look like
> the bus power does get immediately affected depending
> on that capability, isn't it?
>
no.
it checks pm_flags (configured pm features) rather than pm_caps
(supported pm features).

Eliad.