From: <r66093@freescale.com>
To: linux-mmc@vger.kernel.org
Cc: Jerry Huang <Chang-Ming.Huang@freescale.com>,
Gao Guanhua <B22826@freescale.com>,
Xie Xiaobo <X.Xie@freescale.com>, Chris Ball <cjb@laptop.org>
Subject: [PATCH 2/5 v2] ESDHC: set the timeout to the max value
Date: Thu, 22 Dec 2011 18:21:58 +0800 [thread overview]
Message-ID: <1324549321-30796-2-git-send-email-r66093@freescale.com> (raw)
In-Reply-To: <1324549321-30796-1-git-send-email-r66093@freescale.com>
From: Jerry Huang <Chang-Ming.Huang@freescale.com>
When access the card on some FSL platform board (e.g p2020, p1010, mpc8536),
the following error is reported with the timeout value calculated:
mmc0: Got data interrupt 0x00000020 even though no data operation was
in progress.
mmc0: Got data interrupt 0x00000020 even though no data operation was
in progress.
So we skip the calculation of timeout and use the max value to fix it.
Signed-off-by: Gao Guanhua <B22826@freescale.com>
Signed-off-by: Xie Xiaobo <X.Xie@freescale.com>
Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
CC: Chris Ball <cjb@laptop.org>
---
changes for v2:
- change the property to compatible for quirks
drivers/mmc/host/sdhci-pltfm.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index ba36c36..1c254b1 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -74,6 +74,11 @@ void sdhci_get_of_property(struct platform_device *pdev)
if (of_device_is_compatible(np, "fsl,p2020-rev1-esdhc"))
host->quirks |= SDHCI_QUIRK_BROKEN_DMA;
+ if (of_device_is_compatible(np, "fsl,p2020-esdhc")
+ || of_device_is_compatible(np, "fsl,p1010-esdhc")
+ || of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
+ host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
+
clk = of_get_property(np, "clock-frequency", &size);
if (clk && size == sizeof(*clk) && *clk)
pltfm_host->clock = be32_to_cpup(clk);
--
1.7.5.4
next prev parent reply other threads:[~2011-12-22 11:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 10:21 [PATCH 1/5 v2] ESDHC: add PIO mode support r66093
2011-12-22 10:21 ` r66093 [this message]
2011-12-22 10:21 ` [PATCH 3/5 v2] ESDHC: Power management for ESDHC r66093
2011-12-22 10:22 ` [PATCH 4/5 v2] ESDHC: Workaround for data crc error on p1010rdb r66093
2011-12-22 10:22 ` [PATCH 5/5 v2] ESDHC: Fix DMA errors in kernel booting on P1010 r66093
-- strict thread matches above, loose matches on Subject: below --
2012-01-06 5:33 [PATCH 0/1] new version workaround for FSL's eSDHC controller r66093
2012-01-06 5:33 ` [PATCH 1/5 v2] ESDHC: add PIO mode support r66093
2012-01-06 5:33 ` [PATCH 2/5 v2] ESDHC: set the timeout to the max value r66093
2012-01-13 2:36 ` Huang Changming-R66093
2012-01-13 11:54 ` Anton Vorontsov
2012-01-16 3:35 ` Huang Changming-R66093
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324549321-30796-2-git-send-email-r66093@freescale.com \
--to=r66093@freescale.com \
--cc=B22826@freescale.com \
--cc=Chang-Ming.Huang@freescale.com \
--cc=X.Xie@freescale.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox