From: Roland Stigge <stigge@antcom.de>
To: cjb@laptop.org, grant.likely@secretlab.ca,
rob.herring@calxeda.com, rmk+kernel@arm.linux.org.uk,
ulf.hansson@stericsson.com, linus.walleij@linaro.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
aletes.xgr@gmail.com, linux-arm-kernel@lists.infradead.org
Cc: Roland Stigge <stigge@antcom.de>
Subject: [PATCH v3 2/2] mmc: mmci.c: Remove wrong error handling of gpio 0
Date: Sun, 17 Jun 2012 12:11:33 +0200 [thread overview]
Message-ID: <1339927893-8842-3-git-send-email-stigge@antcom.de> (raw)
In-Reply-To: <1339927893-8842-1-git-send-email-stigge@antcom.de>
Zero is a valid GPIO and shouldn't be handled as an error return code from
of_get_named_gpio(). It was a leftover from old code before getting
pdata->gpio_*() was modified.
Signed-off-by: Roland Stigge <stigge@antcom.de>
---
drivers/mmc/host/mmci.c | 5 -----
1 file changed, 5 deletions(-)
--- linux-2.6.orig/drivers/mmc/host/mmci.c
+++ linux-2.6/drivers/mmc/host/mmci.c
@@ -1216,12 +1216,7 @@ static void mmci_dt_populate_generic_pda
int bus_width = 0;
pdata->gpio_wp = of_get_named_gpio(np, "wp-gpios", 0);
- if (!pdata->gpio_wp)
- pdata->gpio_wp = -1;
-
pdata->gpio_cd = of_get_named_gpio(np, "cd-gpios", 0);
- if (!pdata->gpio_cd)
- pdata->gpio_cd = -1;
if (of_get_property(np, "cd-inverted", NULL))
pdata->cd_invert = true;
next prev parent reply other threads:[~2012-06-17 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 10:11 [PATCH] gpio: of_get_named_gpio_flags() return -EPROBE_DEFER if GPIO not yet available Roland Stigge
2012-06-17 10:11 ` [PATCH v3 1/2] mmc: mmci.c: Defer probe() in case of yet uninitialized GPIOs Roland Stigge
2012-06-17 16:21 ` Russell King - ARM Linux
2012-06-17 18:01 ` Linus Walleij
2012-06-17 10:11 ` Roland Stigge [this message]
2012-06-17 18:06 ` [PATCH v3 2/2] mmc: mmci.c: Remove wrong error handling of gpio 0 Linus Walleij
2012-06-17 18:04 ` [PATCH] gpio: of_get_named_gpio_flags() return -EPROBE_DEFER if GPIO not yet available Linus Walleij
2012-06-18 2:06 ` Stephen Warren
2012-06-18 9:19 ` Roland Stigge
2012-06-18 11:24 ` Roland Stigge
2012-06-18 14:50 ` Stephen Warren
2012-06-18 15:08 ` Roland Stigge
2012-06-18 15:12 ` Stephen Warren
2012-06-18 15:23 ` Roland Stigge
2012-06-18 15:45 ` Stephen Warren
2012-06-18 16:40 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339927893-8842-3-git-send-email-stigge@antcom.de \
--to=stigge@antcom.de \
--cc=aletes.xgr@gmail.com \
--cc=cjb@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox