Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@infradead.org>
To: Sekhar Nori <nsekhar@ti.com>
Cc: vinod.koul@intel.com, Matt Porter <mporter@ti.com>,
	Linux DaVinci Kernel List
	<davinci-linux-open-source@linux.davincidsp.com>,
	Linux MMC List <linux-mmc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	grant.likely@secretlab.ca,
	Linux SPI Devel List <spi-devel-general@lists.sourceforge.net>,
	cjb@laptop.org,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API
Date: Sat, 01 Sep 2012 06:32:29 +0530	[thread overview]
Message-ID: <1346461349.2806.4.camel@vkoul-mobl4> (raw)
In-Reply-To: <1346432577.15463.16.camel@vkoul-mobl4>

On Fri, 2012-08-31 at 22:32 +0530, Vinod Koul wrote:
> On Fri, 2012-08-31 at 22:01 +0530, Sekhar Nori wrote:
> > >> Yes, this was the problem. Since the SPI driver now depends on
> > >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in
> > >> Kconfig if SPI is enabled? That should do until the fallback to PIO
> > is
> > >> implemented.
> > > Then this should be enabled for SPI. Care to send a patch
> > 
> > By 'this' you mean the Kconfig select? Then there should be no need of
> > a
> > new patch for this. It can be part of this patch itself, no? 
> Either way is okay for me.
And am in good mood :)

Applied all with this as well

>From b5f14330590118e6a0659255476c0f24ab681e05 Mon Sep 17 00:00:00 2001
From: Vinod Koul <vinod.koul@linux.intel.com>
Date: Sat, 1 Sep 2012 06:29:22 +0530
Subject: [PATCH] spi: davici - make davinci select edma

Reported-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
---
 drivers/spi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 5f84b55..b9fb9a1 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -134,6 +134,7 @@ config SPI_DAVINCI
 	tristate "Texas Instruments DaVinci/DA8x/OMAP-L/AM1x SoC SPI
controller"
 	depends on ARCH_DAVINCI
 	select SPI_BITBANG
+	select TI_EDMA
 	help
 	  SPI master controller for DaVinci/DA8x/OMAP-L/AM1x SPI modules.
 
-- 
1.7.9.5



-- 
~Vinod Koul
Intel Corp.


  reply	other threads:[~2012-09-01  0:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  1:09 [PATCH v3 0/3] DaVinci DMA engine conversion Matt Porter
     [not found] ` <1345684176-21472-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-08-23  1:09   ` [PATCH v3 1/3] dmaengine: add TI EDMA DMA engine driver Matt Porter
2012-08-23  1:09   ` [PATCH v3 2/3] mmc: davinci_mmc: convert to DMA engine API Matt Porter
2012-08-23  1:09   ` [PATCH v3 3/3] spi: spi-davinci: " Matt Porter
     [not found]     ` <1345684176-21472-4-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-08-30 14:16       ` Sekhar Nori
2012-08-30 14:43         ` Matt Porter
2012-08-31  0:55           ` Vinod Koul
2012-08-31 16:02           ` Sekhar Nori
2012-08-31 16:31             ` Vinod Koul
2012-08-31 16:31               ` Sekhar Nori
2012-08-31 17:02                 ` Vinod Koul
2012-09-01  1:02                   ` Vinod Koul [this message]
2012-09-01 13:14                     ` Matt Porter
2012-08-23  6:01 ` [PATCH v3 0/3] DaVinci DMA engine conversion Tom Rini
2012-08-27 15:33 ` Daniel Mack
2012-09-06 13:25   ` Daniel Mack
2012-09-10 20:20     ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346461349.2806.4.camel@vkoul-mobl4 \
    --to=vkoul@infradead.org \
    --cc=cjb@laptop.org \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mporter@ti.com \
    --cc=nsekhar@ti.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox