Re: [PATCH 4/4] drivers/mmc/host/mxs-mmc.c: fix error return code

Marek Vasut
2012-09-17T10:09:39Z

Dear Peter Senna Tschudin,

> From: Peter Senna Tschudin <peter.senna@gmail.com>

The patch description is a bit crap, but otherwise

Acked-by: Marek Vasut <marex@denx.de>

> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
>
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/mmc/host/mxs-mmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 80d1e6d..afd8fdd 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -674,6 +674,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
> if (!ssp->dmach) {
> dev_err(mmc_dev(host->mmc),
> "%s: failed to request dma\n", __func__);
> + ret = -ENODEV;
> goto out_clk_put;
> }

Best regards,
Marek Vasut