From: Tony Prisk <linux@prisktech.co.nz>
To: Chris Ball <cjb@laptop.org>
Cc: arm-linux-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
vt8500-wm8505-linux-kernel@googlegroups.com
Subject: Re: [PATCH v3] MMC: SD/MMC Host Controller for Wondermedia WM8505/WM8650
Date: Mon, 19 Nov 2012 06:44:24 +1300 [thread overview]
Message-ID: <1353260664.23933.0.camel@gitbox> (raw)
In-Reply-To: <87k3tjipmi.fsf@octavius.laptop.org>
On Sat, 2012-11-17 at 21:58 -0500, Chris Ball wrote:
> Hi Tony, thanks for the quick turnaround,
>
> On Sat, Nov 17 2012, Tony Prisk wrote:
> > + regular_irq = irq_of_parse_and_map(np, 0);
> > + dma_irq = irq_of_parse_and_map(np, 1);
> > +
> > + if ((!regular_irq) | (!dma_irq)) {
> > + dev_err(&pdev->dev, "Getting IRQs failed!\n");
>
> I think you meant ||, not |, and you could remove the redundant parens.
>
> Other than that, I think this is ready -- if you want to ACK the above
> change I'll fold it in without having you resend the patch.
>
> Thanks,
>
> - Chris.
Oops - Good catch.
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Regards
Tony P
next prev parent reply other threads:[~2012-11-18 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 2:33 [PATCH v3] MMC: SD/MMC Host Controller for Wondermedia WM8505/WM8650 Tony Prisk
2012-11-18 2:58 ` Chris Ball
2012-11-18 17:44 ` Tony Prisk [this message]
2012-11-18 18:08 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353260664.23933.0.camel@gitbox \
--to=linux@prisktech.co.nz \
--cc=arm-linux-kernel@lists.infradead.org \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=vt8500-wm8505-linux-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox