From: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Guennadi Liakhovetski <g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>
Cc: Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings
Date: Fri, 22 Feb 2013 10:07:39 +0800 [thread overview]
Message-ID: <1361498859.2330.1.camel@jlo-ubuntu-64.nvidia.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1302212333330.10403-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
On Fri, 2013-02-22 at 06:44 +0800, Guennadi Liakhovetski wrote:
> Hi Joseph
>
> On Wed, 20 Feb 2013, Joseph Lo wrote:
> > static int tegra_sdhci_buswidth(struct sdhci_host *host, int bus_width)
> > {
> > - struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> > - struct sdhci_tegra *tegra_host = pltfm_host->priv;
> > u32 ctrl;
> >
> > ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL);
> > - if (tegra_host->is_8bit && bus_width == MMC_BUS_WIDTH_8) {
> > + if (host->mmc->caps == MMC_CAP_8_BIT_DATA &&
>
> Don't you want to check for just one bit? -Šcaps can contain multiple
> flags set:
>
> + if ((host->mmc->caps & MMC_CAP_8_BIT_DATA) &&
>
Ah, yes. Thanks for your review.
Joseph
next prev parent reply other threads:[~2013-02-22 2:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 7:05 [PATCH 0/2] mmc: tegra: use mmc_of_parse to get support of standard MMC DT binding Joseph Lo
2013-02-20 7:05 ` [PATCH 1/2] ARM: dts: tegra: fix the activate polarity of cd-gpio in mmc host Joseph Lo
[not found] ` <1361343902-15223-2-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-20 16:59 ` Stephen Warren
[not found] ` <512500EB.1070802-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-21 8:18 ` Thierry Reding
[not found] ` <20130221081809.GB7718-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2013-02-21 8:30 ` Joseph Lo
2013-02-20 7:05 ` [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings Joseph Lo
[not found] ` <1361343902-15223-3-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-20 17:07 ` Stephen Warren
[not found] ` <512502D7.4090605-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-21 2:23 ` Joseph Lo
[not found] ` <1361413425.5678.8.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2013-02-21 4:20 ` Stephen Warren
[not found] ` <5125A075.5000000-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-21 6:26 ` Joseph Lo
2013-02-21 6:34 ` Joseph Lo
2013-02-21 8:03 ` Thierry Reding
[not found] ` <20130221080306.GA7718-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2013-02-21 8:15 ` Joseph Lo
[not found] ` <1361427997.5678.59.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2013-02-21 18:50 ` Stephen Warren
2013-02-21 22:44 ` Guennadi Liakhovetski
[not found] ` <Pine.LNX.4.64.1302212333330.10403-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2013-02-22 2:07 ` Joseph Lo [this message]
[not found] ` <1361343902-15223-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-21 8:24 ` [PATCH 0/2] mmc: tegra: use mmc_of_parse to get support of standard MMC DT binding Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361498859.2330.1.camel@jlo-ubuntu-64.nvidia.com \
--to=josephl-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox